From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [EGIT PATCH 3/8] Dispose of allocated colors on finalize()
Date: Wed, 1 Oct 2008 19:48:09 +0200 [thread overview]
Message-ID: <200810011948.10041.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <20081001143718.GU21310@spearce.org>
onsdagen den 1 oktober 2008 16.37.18 skrev Shawn O. Pearce:
> Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
[..]
> I think this is wrong. Any color that we get from
[...]
> What was the rationale for disposing of these resources? Did you
> identify that this is a resource leak somewhere? Because I'd like
> to make sure I actually understand the SWT resource model better
> so I don't commit mistakes in the future.
I read the Color javadoc, but not the getSystemColor one. You are right, drop this patch
and the "dispose" hunk in the next patch (which was also a
-- robin
next prev parent reply other threads:[~2008-10-01 17:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 23:53 [EGIT PATCH 1/8] Set table row height for the glog JTable Robin Rosenberg
2008-09-30 23:53 ` [EGIT PATCH 2/8] Move AWTPlotRenderer to its own file Robin Rosenberg
2008-09-30 23:53 ` [EGIT PATCH 3/8] Dispose of allocated colors on finalize() Robin Rosenberg
2008-09-30 23:53 ` [EGIT PATCH 4/8] Align commit text properly in jgit glog Robin Rosenberg
2008-10-01 0:02 ` Robin Rosenberg
2008-10-01 14:38 ` Shawn O. Pearce
2008-10-01 19:31 ` [EGIT PATCH 0/3] jgit glog alignment fixes Robin Rosenberg
2008-10-01 19:31 ` [EGIT PATCH 1/3] Set table row height for the glog JTable Robin Rosenberg
2008-10-01 19:31 ` [EGIT PATCH 2/3] Move AWTPlotRenderer to its own file Robin Rosenberg
2008-10-01 19:31 ` [EGIT PATCH 3/3] Align commit text properly in jgit glog Robin Rosenberg
2008-10-01 14:37 ` [EGIT PATCH 3/8] Dispose of allocated colors on finalize() Shawn O. Pearce
2008-10-01 17:48 ` Robin Rosenberg [this message]
2008-10-01 14:32 ` [EGIT PATCH 2/8] Move AWTPlotRenderer to its own file Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810011948.10041.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).