From: Jeff King <peff@peff.net>
To: David Soria Parra <sn_@gmx.net>
Cc: git@vger.kernel.org, David Soria Parra <dsp@php.net>
Subject: Re: [PATCH] Solaris: Use OLD_ICONV to avoid compile warnings
Date: Wed, 1 Oct 2008 21:08:17 -0400 [thread overview]
Message-ID: <20081002010816.GA27415@coredump.intra.peff.net> (raw)
In-Reply-To: <1222906127-16900-1-git-send-email-sn_@gmx.net>
On Thu, Oct 02, 2008 at 02:08:47AM +0200, David Soria Parra wrote:
> Solaris systems use the old styled iconv(3) call and therefore
> the OLD_ICONV variable should be set. Otherwise we get annoying compile
> warnings.
Acked-by: Jeff King <peff@peff.net>
I set OLD_ICONV on my Solaris build.
Do you also unset NEEDS_LIBICONV (and which version of Solaris are you
running)? Our Makefile sets it to "yes" for Solaris 8, but my build box
requires that it be unset. I'm not sure if my setup is somehow
deficient, or if it is only other versions that need it.
-Peff
next prev parent reply other threads:[~2008-10-02 1:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 0:08 [PATCH] Solaris: Use OLD_ICONV to avoid compile warnings David Soria Parra
2008-10-02 1:08 ` Jeff King [this message]
2008-10-02 10:09 ` David Soria Parra
2008-10-02 15:25 ` Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081002010816.GA27415@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=dsp@php.net \
--cc=git@vger.kernel.org \
--cc=sn_@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).