[PATCH] Solaris: Use OLD_ICONV to avoid compile warnings

[PATCH] Solaris: Use OLD_ICONV to avoid compile warnings

[David Soria Parra]

From: David Soria Parra <dsp@php.net>

Solaris systems use the old styled iconv(3) call and therefore
the OLD_ICONV variable should be set. Otherwise we get annoying compile
warnings.

Signed-off-by: David Soria Parra <dsp@php.net>
---
 Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index 7db2ccc..3abbb4e 100644
--- a/Makefile
+++ b/Makefile
@@ -649,6 +649,7 @@ ifeq ($(uname_S),SunOS)
 	NO_MEMMEM = YesPlease
 	NO_HSTRERROR = YesPlease
 	NO_MKDTEMP = YesPlease
+	OLD_ICONV = UnfortunatelyYes
 	ifeq ($(uname_R),5.8)
 		NEEDS_LIBICONV = YesPlease
 		NO_UNSETENV = YesPlease
-- 
1.6.0.2.569.g798a2a

Re: [PATCH] Solaris: Use OLD_ICONV to avoid compile warnings

[Jeff King]

On Thu, Oct 02, 2008 at 02:08:47AM +0200, David Soria Parra wrote:

> Solaris systems use the old styled iconv(3) call and therefore
> the OLD_ICONV variable should be set. Otherwise we get annoying compile
> warnings.

Acked-by: Jeff King <peff@peff.net>

I set OLD_ICONV on my Solaris build.

Do you also unset NEEDS_LIBICONV (and which version of Solaris are you
running)?  Our Makefile sets it to "yes" for Solaris 8, but my build box
requires that it be unset. I'm not sure if my setup is somehow
deficient, or if it is only other versions that need it.

-Peff

Re: [PATCH] Solaris: Use OLD_ICONV to avoid compile warnings

[David Soria Parra]

Jeff King schrieb:
> Do you also unset NEEDS_LIBICONV (and which version of Solaris are you
> running)?  Our Makefile sets it to "yes" for Solaris 8, but my build box
> requires that it be unset. I'm not sure if my setup is somehow
> deficient, or if it is only other versions that need it.

I'm using OpenSolaris which is identified as SunOS 5.11. Therefore the 
Makefile doesn't set NEEDS_LIBICONV. I'm not sure if it's needed on 
Solaris 8 or not, but it's not needed on OpenSolaris.

David

Re: [PATCH] Solaris: Use OLD_ICONV to avoid compile warnings

[Brandon Casey]

Jeff King wrote:
> On Thu, Oct 02, 2008 at 02:08:47AM +0200, David Soria Parra wrote:
> 
>> Solaris systems use the old styled iconv(3) call and therefore
>> the OLD_ICONV variable should be set. Otherwise we get annoying compile
>> warnings.
> 
> Acked-by: Jeff King <peff@peff.net>
> 
> I set OLD_ICONV on my Solaris build.

Ditto here on 7.

> 
> Do you also unset NEEDS_LIBICONV (and which version of Solaris are you
> running)?

I do not set NEEDS_LIBICONV.

-brandon