From: Petr Baudis <pasky@suse.cz>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Add path_info tests to t/t9500-gitweb-standalone-no-errors.sh
Date: Thu, 2 Oct 2008 17:07:25 +0200 [thread overview]
Message-ID: <20081002150725.GP10544@machine.or.cz> (raw)
In-Reply-To: <20081002145010.19247.44420.stgit@localhost.localdomain>
On Thu, Oct 02, 2008 at 04:52:20PM +0200, Jakub Narebski wrote:
> Note that those tests only that there are no errors nor warnings
> from Perl; they do not check for example if gitweb doesn't use
> ARRAY(0x8e3cc20) instead of correct value in links, etc.
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> This is the test thans to which I have dicovered errors in git_tree()
> fixed in previous email. Nevertheless those two patches are unrelated,
> so they are not numbered.
>
> Those tests check _current_ situation, without $action, not
> $hash_parent parameters possible in path_info.
I didn't test the patch but it all looks sensible.
Acked-by: Petr Baudis <pasky@suse.cz>
next prev parent reply other threads:[~2008-10-02 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 14:52 [PATCH] gitweb: Add path_info tests to t/t9500-gitweb-standalone-no-errors.sh Jakub Narebski
2008-10-02 15:07 ` Petr Baudis [this message]
2008-10-02 16:41 ` Eric Raible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081002150725.GP10544@machine.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).