git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	"Shawn O. Pearce" <spearce@spearce.org>,
	Andreas Ericsson <ae@op5.se>
Subject: Re: [PATCH] format-patch: autonumber by default
Date: Thu, 2 Oct 2008 16:03:33 -0400	[thread overview]
Message-ID: <20081002200333.GA29303@coredump.intra.peff.net> (raw)
In-Reply-To: <1222970291-5337-1-git-send-email-giuseppe.bilotta@gmail.com>

On Thu, Oct 02, 2008 at 07:58:11PM +0200, Giuseppe Bilotta wrote:

> format-patch is often used for multiple patches at once when sending a
> patchset, in which case we want to number the patches; on the other
> hand, single-patches are not usually expected to be numbered.
> 
> The typical behavior expected by format-patch is therefore the one
> obtained by enabling autonumber, which should thus be the default.

I personally do not agree with this default. My usual use of
format-patch is to dump a cluster of miscellaneous patches since
"origin", and then grab the one(s) I want by title.

However, I would not be surprised to find that my use is unlike that of
most other people[1], so I am not opposed to the patch.

[1] Actually, my use has a deficiency, which is that I am often sending
2/4, without nobody having seen 1/4, on which it might actually depend.
This works in practice for me because I am often producing unrelated
janitorial patches for git. :)

So I think the goal is reasonable, but:

> ---
>  builtin-log.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)

Documentation update?

-Peff

  reply	other threads:[~2008-10-02 20:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-02 11:27 [PATCH] format-patch: autonumber by default Giuseppe Bilotta
2008-10-02 12:33 ` Johannes Schindelin
2008-10-02 13:10   ` Giuseppe Bilotta
2008-10-02 13:42     ` Johannes Schindelin
2008-10-02 13:47       ` Giuseppe Bilotta
2008-10-02 14:08         ` Jakub Narebski
2008-10-02 14:14           ` Andreas Ericsson
2008-10-02 17:58             ` Giuseppe Bilotta
2008-10-02 20:03               ` Jeff King [this message]
2008-10-02 20:15                 ` Giuseppe Bilotta
2008-10-02 21:06                   ` Jeff King
2008-10-02 20:17               ` Brian Gernhardt
2008-10-02 20:36                 ` Brian Gernhardt
2008-10-02 20:41                 ` Brian Gernhardt
2008-10-02 20:50                   ` Brian Gernhardt
2008-10-02 20:55                 ` [PATCH v2] " Brian Gernhardt
2009-11-04 11:20                   ` Eric W. Biederman
2009-11-04 17:38                     ` Junio C Hamano
2009-11-04 17:48                     ` Brian Gernhardt
2008-10-02 13:43     ` [PATCH] " Andreas Ericsson
2008-10-02 13:54     ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081002200333.GA29303@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=ae@op5.se \
    --cc=git@vger.kernel.org \
    --cc=giuseppe.bilotta@gmail.com \
    --cc=jnareb@gmail.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).