From: David Bryson <david@statichacks.org>
To: git@vger.kernel.org
Subject: [PATCH] Use "git_config_string" to simplify "remote.c" code in "handle_config"
Date: Thu, 2 Oct 2008 20:39:37 -0700 [thread overview]
Message-ID: <20081003033937.GA11594@eratosthenes.cryptobackpack.org> (raw)
Signed-off-by: David Bryson <david@statichacks.org>
I tried to keep with the naming/coding conventions that I found in
remote.c. Feedback welcome.
---
remote.c | 19 ++++++++++---------
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/remote.c b/remote.c
index 3f3c789..893a739 100644
--- a/remote.c
+++ b/remote.c
@@ -305,6 +305,7 @@ static int handle_config(const char *key, const char *value, void *cb)
{
const char *name;
const char *subkey;
+ const char *v;
struct remote *remote;
struct branch *branch;
if (!prefixcmp(key, "branch.")) {
@@ -314,15 +315,15 @@ static int handle_config(const char *key, const char *value, void *cb)
return 0;
branch = make_branch(name, subkey - name);
if (!strcmp(subkey, ".remote")) {
- if (!value)
- return config_error_nonbool(key);
- branch->remote_name = xstrdup(value);
+ if (git_config_string(&v, key, value) )
+ return -1;
+ branch->remote_name = v;
if (branch == current_branch)
default_remote_name = branch->remote_name;
} else if (!strcmp(subkey, ".merge")) {
- if (!value)
- return config_error_nonbool(key);
- add_merge(branch, xstrdup(value));
+ if (git_config_string(&v, key, value ))
+ return -1;
+ add_merge(branch, v);
}
return 0;
}
@@ -334,9 +335,9 @@ static int handle_config(const char *key, const char *value, void *cb)
return 0;
rewrite = make_rewrite(name, subkey - name);
if (!strcmp(subkey, ".insteadof")) {
- if (!value)
- return config_error_nonbool(key);
- add_instead_of(rewrite, xstrdup(value));
+ if (git_config_string(&v, key, value ))
+ return -1;
+ add_instead_of(rewrite, v);
}
}
if (prefixcmp(key, "remote."))
--
1.6.0.2
next reply other threads:[~2008-10-03 3:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 3:39 David Bryson [this message]
2008-10-03 5:28 ` [PATCH] Use "git_config_string" to simplify "remote.c" code in "handle_config" Andreas Ericsson
2008-10-03 20:06 ` David Bryson
2008-10-04 22:46 ` Alex Riesen
2008-10-06 19:49 ` David Bryson
2008-10-06 14:13 ` Johannes Schindelin
2008-10-06 19:53 ` David Bryson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081003033937.GA11594@eratosthenes.cryptobackpack.org \
--to=david@statichacks.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).