git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: Stephen Haberman <stephen@exigencecorp.com>
Cc: Jakub Narebski <jnareb@gmail.com>,
	marceloribeiro <marcelo@sonnay.com>,
	git@vger.kernel.org
Subject: Re: Numeric Revision Names?
Date: Fri, 3 Oct 2008 19:13:52 +0200	[thread overview]
Message-ID: <200810031913.55594.trast@student.ethz.ch> (raw)
In-Reply-To: <20081003115557.08d80c2f.stephen@exigencecorp.com>

[-- Attachment #1: Type: text/plain, Size: 1770 bytes --]

Stephen Haberman wrote:
> 
> > Second, in my opinion revision numbers are not that useful for
> > projects with large number of commits (where revision number might be
> > something like r4321), and nonlinear history (you don't know how r4555
> > relates to r4556: they might be on different branches).
> 
> For projects that do have a central authority (e.g. internal corporate
> projects), revision numbers make more sense.
> 
> Granted, they are on separate branches (like svn), but the nice thing
> about them is that they are monotonically increasing. E.g. our qa
> people love numbers--the bug fix ticket says dev just put in
> r100...qa/production box says it is on r95. Doesn't matter the
> branch/whatever, they know the box doesn't have r100. Now, right, if
> its r105, it is trickier, although we also throw in branch name (e.g.
> topica-r100) which means no false positives but can lead to false
> negatives.

I wonder how that constitutes an argument for revision numbers.

First, the _only_ guarantee you get out of monotonically increasing
revision numbers is that they're ... monotonically increasing.  You
might as well use the commit (not author!) timestamp for that purpose
(assuming your clocks are all synced).  They do not convey history
membership, only history non-membership, for the same obvious reason
that commit timestamps do.

Second, Git can do the check you mention above much more accurately.
If you tell QA that the fix is in 123abc, then 'git branch --contains
123abc' lists all local branches that have the fix, 'git describe
--contains 123abc' gives you the nearest tag (i.e. usually the
lowest-numbered release version number) having the fix, etc.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2008-10-03 17:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-03 12:37 Numeric Revision Names? marceloribeiro
2008-10-03 12:41 ` Robin Burchell
2008-10-03 12:44 ` Bruce Stephens
2008-10-03 16:07 ` Jakub Narebski
2008-10-03 16:55   ` Stephen Haberman
2008-10-03 17:13     ` Thomas Rast [this message]
2008-10-03 17:42       ` Stephen Haberman
2008-10-05  3:13         ` André Goddard Rosa
2008-10-05  9:19           ` Alex Riesen
2008-10-03 17:14     ` Jeff King
2008-10-03 17:37       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810031913.55594.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=marcelo@sonnay.com \
    --cc=stephen@exigencecorp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).