From: David Bryson <david@statichacks.org>
To: Andreas Ericsson <ae@op5.se>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Use "git_config_string" to simplify "remote.c" code in "handle_config"
Date: Fri, 3 Oct 2008 13:06:13 -0700 [thread overview]
Message-ID: <20081003200613.GO20571@eratosthenes.cryptobackpack.org> (raw)
In-Reply-To: <48E5AD8A.4070301@op5.se>
On Fri, Oct 03, 2008 at 07:28:42AM +0200 or thereabouts, Andreas Ericsson wrote:
> David Bryson wrote:
>> Signed-off-by: David Bryson <david@statichacks.org>
>> I tried to keep with the naming/coding conventions that I found in
>> remote.c. Feedback welcome.
>> ---
>> remote.c | 19 ++++++++++---------
>> 1 files changed, 10 insertions(+), 9 deletions(-)
>> diff --git a/remote.c b/remote.c
>> index 3f3c789..893a739 100644
>> --- a/remote.c
>> +++ b/remote.c
>> @@ -305,6 +305,7 @@ static int handle_config(const char *key, const char
>> *value, void *cb)
>> {
>> const char *name;
>> const char *subkey;
>> + const char *v;
>
>
> Not very mnemonic. I'm sure you can think up a better name, even if it's
> a long one. Git is notoriously sparse when it comes to comments. We rely
> instead on self-explanatory code.
>
Oh I agree entirely, it is quite vague, however like I mentioned I tried
to keep to the conventios in the file. This strategy(v) is used in several
other places in remote.c, if this is Bad Code, then I have no problem
changing it.
Thoughts from anybody else ?
next prev parent reply other threads:[~2008-10-03 20:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 3:39 [PATCH] Use "git_config_string" to simplify "remote.c" code in "handle_config" David Bryson
2008-10-03 5:28 ` Andreas Ericsson
2008-10-03 20:06 ` David Bryson [this message]
2008-10-04 22:46 ` Alex Riesen
2008-10-06 19:49 ` David Bryson
2008-10-06 14:13 ` Johannes Schindelin
2008-10-06 19:53 ` David Bryson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081003200613.GO20571@eratosthenes.cryptobackpack.org \
--to=david@statichacks.org \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).