From: Dmitry Potapov <dpotapov@gmail.com>
To: Ed Avis <eda@waniasset.com>
Cc: git@vger.kernel.org
Subject: Re: Build bug report: 'make check' needs sparse, but configure doesn't check it
Date: Sun, 5 Oct 2008 04:34:46 +0400 [thread overview]
Message-ID: <20081005003446.GN21650@dpotapov.dyndns.org> (raw)
In-Reply-To: <loom.20081004T131652-828@post.gmane.org>
On Sat, Oct 04, 2008 at 01:19:56PM +0000, Ed Avis wrote:
> When you build git-1.6.0.2 and 'make check', it tries to run sparse and fails if
> sparse is not there. But the configure script does not check sparse is
> installed.
>
> I suggest that 'make check' skip the sparse tests if sparse is not there. As I
> understand it, they are really more for the developers to get a report of
> possible errors in the source code and not to test that the built executables
> work, so it would not be dangerous to just skip running those tests for ordinary
> users who don't have the tool.
The whole point of 'make check' is to run 'sparce' on all files.
Granted, you may not have 'sparce' installed, but then why do you
want to run 'make check'? It makes no sense. If you want to build
and to test the resulting binaries then you run 'make test'.
Dmitry
next prev parent reply other threads:[~2008-10-05 0:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-04 13:19 Build bug report: 'make check' needs sparse, but configure doesn't check it Ed Avis
2008-10-05 0:34 ` Dmitry Potapov [this message]
2008-10-05 9:46 ` Ed Avis
2008-10-06 6:58 ` Shawn O. Pearce
2008-10-06 11:28 ` Ed Avis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081005003446.GN21650@dpotapov.dyndns.org \
--to=dpotapov@gmail.com \
--cc=eda@waniasset.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).