git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Marc Weber <marco-oweber@gmx.de>, git@vger.kernel.org
Subject: Re: What about renaming ga -i [r]evert to [r]eset ?
Date: Sun, 5 Oct 2008 12:41:25 -0400	[thread overview]
Message-ID: <20081005164124.GA31903@coredump.intra.peff.net> (raw)
In-Reply-To: <20081005152654.GA13618@gmx.de>

On Sun, Oct 05, 2008 at 05:26:54PM +0200, Marc Weber wrote:

> You can get the patch from git://mawercer.de/git_my_patches branch
> revert_to_reset_renaming
> 
> Maybe someone of you beeing more familiar with perl,
> git-add--interactive and git can review it maybe telling me what should
> be done so that it can be committed upstream?

Please take a look at Documentation/SubmittingPatches. In particular:

  - this change should be split into two different patches (one for
    s/revert/reset, and one for adding "checkout").

  - patches should be sent to the list for review, as described in
    SubmittingPatches

  - commit messages should be formatted in the usual git way. I.e,

      one-line description of the change

      more elaborate description of the change, including
      details of the change, but most importantly discussing
      the rationale for the change. In order for your patch to
      be accepted, you must explain _why_ you think it's a good
      idea.

-Peff

  reply	other threads:[~2008-10-05 16:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-05 15:26 What about renaming ga -i [r]evert to [r]eset ? Marc Weber
2008-10-05 16:41 ` Jeff King [this message]
2008-10-05 21:46   ` [PATCH 2] renaming git add -i [r]evert -> reset and adding gitt add -i [c]heckout Marc Weber
2008-10-05 22:11     ` Jeff King
2008-10-06 14:46       ` [PATCH 1/2] add--interactive: rename [r]evert command to [r]eset Marc Weber
2008-10-06 14:49         ` [PATCH 2/2] add--interactive: added [c]heckout Marc Weber
2008-10-06 14:51           ` Shawn O. Pearce
2008-10-06 15:55             ` Marc Weber
2008-10-06 14:55         ` [PATCH 1/2] add--interactive: rename [r]evert command to [r]eset Shawn O. Pearce
2008-10-06 15:51           ` Marc Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081005164124.GA31903@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=marco-oweber@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).