git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] rebase --no-verify
Date: Mon, 6 Oct 2008 07:30:28 -0700	[thread overview]
Message-ID: <20081006143028.GC7684@spearce.org> (raw)
In-Reply-To: <20081006141429.6117@nanako3.lavabit.com>

Nanako Shiraishi <nanako3@lavabit.com> wrote:
> It is sometimes desirable to disable the safety net of pre-rebase hook
> when the user knows what he is doing (for example, when the original
> changes on the branch have not been shown to the public yet).
> 
> This teaches --no-verify option to git-rebase, which is similar to the way
> pre-commit hook is bypassed by git-commit.

Looks good.
 
>     It probably is better to fix "rebase -i" to share more code with the main
>     "rebase" script to avoid duplicated run-pre-rebase-hook function, but it
>     is beyond what I can do right now.  Perhaps people more smart and
>     beautiful than me can help (^_^;)

True.  But its already a mess.  git-sequencer is probably the
right approach to merge it all together.
 
>  git-rebase--interactive.sh |   10 +++++++++-
>  git-rebase.sh              |    7 ++++++-
>  t/t3409-rebase-hook.sh     |   16 ++++++++++++++++
>  3 files changed, 31 insertions(+), 2 deletions(-)

Docs?

-- 
Shawn.

  reply	other threads:[~2008-10-06 14:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-03  0:10 git rebase -- a suggestion Robin Burchell
2008-10-05 13:26 ` Nanako Shiraishi
2008-10-06  5:14 ` [PATCH] Teach rebase -i to honor pre-rebase hook Nanako Shiraishi
2008-10-06  5:14 ` [PATCH] rebase --no-verify Nanako Shiraishi
2008-10-06 14:30   ` Shawn O. Pearce [this message]
2008-10-06 16:07     ` Stephan Beyer
2008-10-06 16:14       ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081006143028.GC7684@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=nanako3@lavabit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).