From: "Shawn O. Pearce" <spearce@spearce.org>
To: Stephan Beyer <s-beyer@gmx.net>
Cc: Nanako Shiraishi <nanako3@lavabit.com>, git@vger.kernel.org
Subject: Re: [PATCH] rebase --no-verify
Date: Mon, 6 Oct 2008 09:14:24 -0700 [thread overview]
Message-ID: <20081006161424.GE8203@spearce.org> (raw)
In-Reply-To: <20081006160716.GC14479@leksak.fem-net>
Stephan Beyer <s-beyer@gmx.net> wrote:
> Shawn O. Pearce wrote:
> > > It probably is better to fix "rebase -i" to share more code with the main
> > > "rebase" script to avoid duplicated run-pre-rebase-hook function, but it
> > > is beyond what I can do right now. Perhaps people more smart and
> > > beautiful than me can help (^_^;)
> >
> > True. But its already a mess. git-sequencer is probably the
> > right approach to merge it all together.
>
> Hmm, I don't think I like the pre-rebase hook in sequencer. The user
> scripts (git-rebase--interactive.sh and git-rebase.sh) should run them;
> that's ok.
Sorry, my remark wasn't about the rebase hook as much as it was
that there is a good chunk of code duplicated between the two
rebase implementations and all of them were implemented through
git-sequencer its likely they could all collapse into a single
common "git rebase" wrapper script which just sets up the call
to git-sequencer.
So yea, I do agree, the pre-rebase hook should be in rebase, not
git-sequencer, but git-sequencer probably offers a great way to
get the different rebase implementations combined together.
> I think, for the moment it is ok to have the code duplicated. After
> sequencer has merged into master[1], I will probably take a look at
> merging git-rebase.sh and git-rebase--interactive.sh if somebody
> else is interested in it and if there is a good way to achieve that.
Yup, exactly my thoughts. I just didn't express them well.
--
Shawn.
prev parent reply other threads:[~2008-10-06 16:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 0:10 git rebase -- a suggestion Robin Burchell
2008-10-05 13:26 ` Nanako Shiraishi
2008-10-06 5:14 ` [PATCH] Teach rebase -i to honor pre-rebase hook Nanako Shiraishi
2008-10-06 5:14 ` [PATCH] rebase --no-verify Nanako Shiraishi
2008-10-06 14:30 ` Shawn O. Pearce
2008-10-06 16:07 ` Stephan Beyer
2008-10-06 16:14 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081006161424.GE8203@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=nanako3@lavabit.com \
--cc=s-beyer@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).