git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git/spearce.git (Oct 2008, #01; Mon, 06)
Date: Tue, 7 Oct 2008 07:50:04 -0700	[thread overview]
Message-ID: <20081007145004.GA4674@spearce.org> (raw)
In-Reply-To: <20081006210303.GA30812@coredump.intra.peff.net>

Jeff King <peff@peff.net> wrote:
> On Mon, Oct 06, 2008 at 09:59:43AM -0700, Shawn O. Pearce wrote:
> 
> > * jk/diff-convfilter (Sun Oct 5 17:43:45 2008 -0400) 4 commits
> >  - diff: add filter for converting binary to text
> >  - diff: introduce diff.<driver>.binary
> >  - diff: unify external diff and funcname parsing code
> >  - t4012: use test_cmp instead of cmp
> > 
> > A general cleanup on how diff drivers are implemented.  Its still
> > missing documentation updates and tests but doesn't break anything
> > current as far as I can tell.  It needs more review before it can
> > be slated for 'next'.
> 
> I should note, too, that this is in direct competition with Matthieu
> Moy's "Implementation of a textconv filter for easy custom diff" posted
> about a week ago. So if you are reviewing this series, please review
> both and decide which you think is more sensible.

To be clear, Jeff's series is in pu because it seems reasonable on
the surface and applied cleanly to my master branch.  Matthieu's
branch didn't apply cleanly, and I didn't really have the time to
figure out why and hand fix it.

So my carrying of Jeff's series and not Matthieu's is not an
endorsement one way or the other.  It was simply a matter of trying
to help the topic get exposure with the least amount of effort on
my part.

-- 
Shawn.

      reply	other threads:[~2008-10-07 14:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-06 16:59 What's cooking in git/spearce.git (Oct 2008, #01; Mon, 06) Shawn O. Pearce
2008-10-06 20:48 ` Stephen Haberman
2008-10-06 21:03 ` Jeff King
2008-10-07 14:50   ` Shawn O. Pearce [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081007145004.GA4674@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).