From: Miklos Vajna <vmiklos@frugalware.org>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH maint] builtin-merge.c: fix memory under-allocation
Date: Thu, 9 Oct 2008 02:17:27 +0200 [thread overview]
Message-ID: <20081009001727.GP536@genesis.frugalware.org> (raw)
In-Reply-To: <ZuhLzndR5Uvj7-_NyasP-FHF3AqTyLx-0sjNHMd0BC3LXC8LdLqBeQ@cipher.nrlssc.navy.mil>
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
On Wed, Oct 08, 2008 at 07:07:54PM -0500, Brandon Casey <casey@nrlssc.navy.mil> wrote:
> While we're at it, change the allocation to reference the variable it is
> allocating memory for to try to prevent a similar mistake if the type is
> changed in the future.
If this is really a problem, then I think it would be good to mention
this in Documentation/CodingGuidelines.
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-10-09 0:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 0:07 [PATCH maint] builtin-merge.c: fix memory under-allocation Brandon Casey
2008-10-09 0:17 ` Miklos Vajna [this message]
2008-10-09 0:27 ` Brandon Casey
2008-10-09 11:12 ` Junio C Hamano
2008-10-09 14:15 ` Brandon Casey
2008-10-09 14:49 ` Miklos Vajna
2008-10-09 15:13 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081009001727.GP536@genesis.frugalware.org \
--to=vmiklos@frugalware.org \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).