From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Miklos Vajna <vmiklos@frugalware.org>,
Alex Riesen <raa.lkml@gmail.com>,
Constantine Plotnikov <constantine.plotnikov@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Implement git clone -v
Date: Thu, 9 Oct 2008 08:20:28 -0700 [thread overview]
Message-ID: <20081009152028.GA29829@spearce.org> (raw)
In-Reply-To: <7vr66qown3.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
> Miklos Vajna <vmiklos@frugalware.org> writes:
>
> > The new -v option forces the progressbar, even in case the output is not
> > a terminal.
> >
> > Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
>
> The patch made me wonder why this new feature had to be implemented in the
> first place and had me look up the message the patch was an follow-up to.
> For somebody who would not recall the original request-for-feature (that
> includes you 6 months from now), it would have been easier to understand
> the context if the commit message said what the intended purpose of this
> (i.e. "have it read by an IDE").
I'm amending the message as the following:
--8<--
Implement git clone -v
The new -v option forces the progressbar, even in case the output
is not a terminal. This can be useful if the caller is an IDE or
wrapper which wants to scrape the progressbar from stderr and show
its information in a different format.
Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
--
--
Shawn.
next prev parent reply other threads:[~2008-10-09 15:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 20:01 Forcing progerss output for clone Constantine Plotnikov
2008-10-04 21:42 ` Alex Riesen
2008-10-06 22:19 ` [PATCH] Implement git clone -v Miklos Vajna
2008-10-07 6:21 ` Alex Riesen
2008-10-07 19:39 ` Miklos Vajna
2008-10-08 6:02 ` Shawn O. Pearce
2008-10-08 6:25 ` Alex Riesen
2008-10-08 23:40 ` Miklos Vajna
2008-10-09 11:06 ` Junio C Hamano
2008-10-09 15:20 ` Shawn O. Pearce [this message]
2008-10-09 21:26 ` Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081009152028.GA29829@spearce.org \
--to=spearce@spearce.org \
--cc=constantine.plotnikov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raa.lkml@gmail.com \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).