From: Jakub Narebski <jnareb@gmail.com>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>,
Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCHv2] gitweb: refactor input parameters parse/validation
Date: Fri, 10 Oct 2008 10:37:30 +0200 [thread overview]
Message-ID: <200810101037.31037.jnareb@gmail.com> (raw)
In-Reply-To: <1223457985-27094-1-git-send-email-giuseppe.bilotta@gmail.com>
On Wed, 8 Oct 2008, Giuseppe Bilotta wrote:
> Since input parameters can be obtained both from CGI parameters and
> PATH_INFO, we would like most of the code to be agnostic about the way
> parameters were retrieved. We thus collect all the parameters into the
> new %input_params hash, delaying validation after the collection is
> completed.
>
> Although the kludge removal is minimal at the moment, it makes life much
> easier for future expansions such as more extensive PATH_INFO use or
> other form of input such as command-line support.
>
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Very nice.
Acked-by: Jakub Narebski <jnareb@gmail.com>
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2008-10-10 8:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 17:19 [PATCH] gitweb: refactor input parameters parse/validation Giuseppe Bilotta
2008-10-07 10:57 ` Jakub Narebski
2008-10-07 12:42 ` Giuseppe Bilotta
2008-10-07 14:39 ` Jakub Narebski
2008-10-08 9:10 ` Giuseppe Bilotta
2008-10-08 9:45 ` Jakub Narebski
2008-10-08 9:26 ` [PATCHv2] " Giuseppe Bilotta
2008-10-10 8:37 ` Jakub Narebski [this message]
2008-10-10 15:01 ` Shawn O. Pearce
2008-10-10 17:33 ` Giuseppe Bilotta
2008-10-10 18:42 ` [PATCHv3] " Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810101037.31037.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=pasky@suse.cz \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).