git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Haberman <stephen@exigencecorp.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: What's cooking in git/spearce.git (Oct 2008, #02; Sun, 12)
Date: Mon, 13 Oct 2008 01:37:52 -0500	[thread overview]
Message-ID: <20081013013752.8fc16695.stephen@exigencecorp.com> (raw)
In-Reply-To: <20081012212543.GG4856@spearce.org>


> * sh/maint-rebase3 (Sun Oct 5 23:26:52 2008 -0500) 1 commit
>  - rebase--interactive: fix parent rewriting for dropped commits
> 
> A prior version of sh/rebase-i-p.  This should be dropped.

maint-rebase3 is actually a separate issue than sh/rebase-i-p.

maint-rebase3 deals with commits dropped because they are recognized as
cherry picks, while rebase-i-p deals with commits that can be ignored
from the todo because their parents are not being changed.

I'm surprised they both applied cleanly to pu--I was expecting a
conflict, as I noted in one of my posts. I just fetched pu and they
seem to have each broke the each other's tests as well.

To fix this, I have some local changes to pu that gets both tests
passing again. Should I submit my integration changes as a diff on top
of pu? Or should I try and integrate the two patches into one series?

Technically these two fixes are different things, and I assert you
could apply one or the other, but if you apply both, they require
integration, so I'm not sure what to do.

(...nuts, t3404#22 is failing, so my maint3-rebase/rebase-i-p
integration patch is not quite ready yet.)

(I also have a test comment typo and test_expect_failure change to make
to rebase-i-p from Junio's feedback and would like to know the
preferred way to submit those--e.g. a patch on top of your pu, a patch
on top of the existing series, or a new series all together. Given it
is not next, I'm guessing a new series all together.)

Thanks,
Stephen

  parent reply	other threads:[~2008-10-13  6:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-12 21:25 What's cooking in git/spearce.git (Oct 2008, #02; Sun, 12) Shawn O. Pearce
2008-10-13  2:05 ` Junio C Hamano
2008-10-13  3:49   ` Junio C Hamano
2008-10-13  6:37 ` Stephen Haberman [this message]
2008-10-13 14:25   ` Junio C Hamano
2008-10-13 23:17 ` [PATCH] rebase: Document --no-verify option to bypass pre-rebase hook Nanako Shiraishi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081013013752.8fc16695.stephen@exigencecorp.com \
    --to=stephen@exigencecorp.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).