From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Petr Baudis <pasky@suse.cz>
Subject: Re: Puzzled by a t9500 test failure
Date: Mon, 13 Oct 2008 17:22:46 -0700 [thread overview]
Message-ID: <20081014002246.GA4856@spearce.org> (raw)
In-Reply-To: <7vhc7g8257.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
> "Shawn O. Pearce" <spearce@spearce.org> writes:
>
> > Junio C Hamano <gitster@pobox.com> wrote:
> >> With recent tip of 'master':
> >>
> >> $ make
> >> $ mkdir t/trash
> >> $ cd t && sh t9500-*.sh -i
> >>
> >> fails at the very first test. Can anybody figure out why?
> >
> > Hmmph. Near as I can tell its because gitweb.log has this in it:
> >
> > $ cat gitweb.log
> > [Mon Oct 13 23:43:36 2008] gitweb.perl: Use of uninitialized value in scalar chomp at /home/sop/local/maint-git/t/../gitweb/gitweb.perl line 1811.
> > [Mon Oct 13 23:43:36 2008] gitweb.perl: Use of uninitialized value in addition (+) at /home/sop/local/maint-git/t/../gitweb/gitweb.perl line 3772.
> > HASH..
> >
> > The test does a grep for '[[]' and if it matches, fails. I'm not
> > sure why this started showing up now. Obviously I merged something
> > that failed the test suite, but I was pretty sure I had run the full
> > set before publishing anything.
>
> Nothing as far as I can tell changed while you were the pumpking.
>
> I was just wondering why the presense of that extra, should-be-unused,
> t/trash directory affects the outcome of the test.
Seriously?
Oh. Some time with strace later...
Its because Perl totally borked the $projectroot path when it was
looking at $GIT_DIR/ctags. $GIT_DIR has a space in the path and
Perl bound the first aprt, opened it, but cannot open the second
part of the $GIT_DIR/ctags string because it doesn't exist.
The code in question is the new tag cloud code in gitweb that
Peter added. So bisect is still correct.
My guess is its the code in git_get_project_ctags(), around
l.1804-1816.
--
Shawn.
prev parent reply other threads:[~2008-10-14 0:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 23:40 Puzzled by a t9500 test failure Junio C Hamano
2008-10-13 23:48 ` Shawn O. Pearce
2008-10-14 0:08 ` Shawn O. Pearce
2008-10-15 4:27 ` [PATCH] Fix reading of cloud tags Junio C Hamano
2008-10-14 0:13 ` Puzzled by a t9500 test failure Junio C Hamano
2008-10-14 0:22 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014002246.GA4856@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).