From: "Uwe Kleine-König" <ukleinek@strlen.de>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Pierre Habouzit <madcoder@debian.org>,
Erez Zilber <erezzi.list@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
open-iscsi@googlegroups.com, Junio C Hamano <gitster@pobox.com>,
Andreas Ericsson <ae@op5.se>
Subject: Re: [PATCH] doc: enhance git describe --tags help
Date: Wed, 15 Oct 2008 22:05:34 +0200 [thread overview]
Message-ID: <20081015200534.GA32686@strlen.de> (raw)
In-Reply-To: <20080930222646.GP21310@spearce.org>
Hi Shawn,
On Tue, Sep 30, 2008 at 03:26:46PM -0700, Shawn O. Pearce wrote:
> Its a change in behavior. Today users are getting annotated tags
> back from `git describe --tags` even if lightweight tags are closer.
> Once this code change is in they'll start to get lightweight tags.
>
> Previously `git describe --tags` never gave a lightweight tag if
> there was at least one annotated tag in the history. Now it will
> start to give the lightweight tags. Some users may see that as a
> breakage.
Right, and previously `git describe` didn't differ from `git describe
--tags` in the presence of at least one annotated tag. This is the main
reason for me to believe that this breakage doesn't hurt that much.
> Especially after the 1.6 "dashless" change...
I didn't get why the "dashless" change is relevant here. IMHO this one
is/was harder for the user because it changed every command, and they
had to start using bash completion if they didn't before. This one
should only hurt the users of "git describe --tags", and I assume there
are not that many. Still more as the documentation describes the
behaviour the patch implements.
Best regards
Uwe
next prev parent reply other threads:[~2008-10-15 20:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-28 13:48 git-describe doesn't show the most recent tag Erez Zilber
2008-09-28 13:55 ` Pierre Habouzit
2008-09-28 14:29 ` Erez Zilber
2008-09-28 14:39 ` Pierre Habouzit
2008-09-28 15:03 ` Pierre Habouzit
2008-09-28 15:12 ` [PATCH] doc: enhance git describe --tags help Pierre Habouzit
2008-09-29 15:01 ` Shawn O. Pearce
2008-09-30 8:39 ` Pierre Habouzit
2008-10-10 16:59 ` [RFC PATCH] describe: Make --tags and --all match lightweight tags more often Shawn O. Pearce
2008-10-10 17:12 ` Pierre Habouzit
2008-10-10 18:18 ` Junio C Hamano
2008-10-13 14:32 ` Shawn O. Pearce
2008-10-13 14:39 ` [PATCH v2] " Shawn O. Pearce
2008-10-15 12:54 ` Santi Béjar
2008-10-11 22:47 ` [RFC PATCH] " Andreas Ericsson
2008-10-12 18:00 ` Shawn O. Pearce
2008-10-12 18:13 ` Andreas Ericsson
2008-10-12 18:29 ` Uwe Kleine-König
2008-09-30 9:56 ` [PATCH] doc: enhance git describe --tags help Uwe Kleine-König
2008-09-30 10:09 ` Andreas Ericsson
2008-09-30 19:04 ` Shawn O. Pearce
2008-09-30 22:14 ` Uwe Kleine-König
2008-09-30 22:26 ` Shawn O. Pearce
2008-10-15 20:05 ` Uwe Kleine-König [this message]
2008-09-28 15:05 ` git-describe doesn't show the most recent tag Erez Zilber
2008-09-28 14:51 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081015200534.GA32686@strlen.de \
--to=ukleinek@strlen.de \
--cc=ae@op5.se \
--cc=erezzi.list@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
--cc=open-iscsi@googlegroups.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).