StGIT 0.14.3: extra space is added before e-mail on export after "stg edit"

StGIT 0.14.3: extra space is added before e-mail on export after "stg edit"

[Andrey Borzenkov]

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

Hi,

Funny problem. I have following export template:

Subject: [PATCH] %(shortdescr)s
From: %(authname)s %(authemail)s

%(longdescr)s
Signed-off-by: %(authname)s %(authemail)s

---

%(diffstat)s

So after "stg new", edit, "stg refres" (and any number of "stg refresh"es)
it exports OK. But once I did "stg edit patch", all subsequent "stg export patch"
will give (assuming author is me@foo.net):

From: My Name < me@foo.net>
...
Signed-off-by: My Name < me@foo.net>

Notice extra space between "<" and e-mail.

TIA

-andrey

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: StGIT 0.14.3: extra space is added before e-mail on export after "stg edit"

[Catalin Marinas]

2008/10/15 Andrey Borzenkov <arvidjaar@mail.ru>:
> Funny problem. I have following export template:
>
> Subject: [PATCH] %(shortdescr)s
> From: %(authname)s %(authemail)s
>
> %(longdescr)s
> Signed-off-by: %(authname)s %(authemail)s

The default templates contain "%(authname)s <%(authemail)s>", i.e.
with the angle brackets arount authemail and I've never seen this
problem. Does it work if you change them (or use the default
templates)?

-- 
Catalin

Re: StGIT 0.14.3: extra space is added before e-mail on export after "stg edit"

[Andrey Borzenkov]

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

On Saturday 18 October 2008, Catalin Marinas wrote:
> 2008/10/15 Andrey Borzenkov <arvidjaar@mail.ru>:
> > Funny problem. I have following export template:
> >
> > Subject: [PATCH] %(shortdescr)s
> > From: %(authname)s %(authemail)s
> >
> > %(longdescr)s
> > Signed-off-by: %(authname)s %(authemail)s
> 
> The default templates contain "%(authname)s <%(authemail)s>", i.e.
> with the angle brackets arount authemail and I've never seen this
> problem. Does it work if you change them (or use the default
> templates)?
> 

Well, my GIT_AUTHOR_EMAIL was with angle brackets. I do not remember, why
(apparently I had some issues in the past). I stripped brackets and changed
template, now it seems to work. I was never sure what exactly e-mail should
like like.

Thank you!

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]