From: Alex Riesen <raa.lkml@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Alexander Gavrilov <angavrilov@gmail.com>,
git@vger.kernel.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [RFC PATCH] commit: Warn about encodings unsupported by iconv.
Date: Tue, 21 Oct 2008 08:17:54 +0200 [thread overview]
Message-ID: <20081021061754.GA4656@blimp.localdomain> (raw)
In-Reply-To: <7vmygy233r.fsf@gitster.siamese.dyndns.org>
Junio C Hamano, Tue, Oct 21, 2008 02:39:36 +0200:
> I actually have an alternative approach to suggest.
>
> How about adding a new i18n.commit-reencode-logmessage option (boolean),
> and when it is set, we actually re-encode from i18n.commitencoding to
> "utf-8" before creating the commit object (and obviously we do not store
> "encoding" header in the resulting commit)? When the conversion fails, we
> know it failed, so the warning you added does make sense in that context.
Maybe make the option a string, and allow to choose the target
encoding (not only utf8, but anything user wishes)?
next prev parent reply other threads:[~2008-10-21 6:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 21:25 [RFC PATCH] commit: Warn about encodings unsupported by iconv Alexander Gavrilov
2008-10-21 0:39 ` Junio C Hamano
2008-10-21 6:17 ` Alex Riesen [this message]
2008-10-21 10:43 ` Alexander Gavrilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021061754.GA4656@blimp.localdomain \
--to=raa.lkml@gmail.com \
--cc=angavrilov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).