From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Eric Wong" <normalperson@yhbt.net>,
"Björn Steinbrink" <B.Steinbrink@gmx.de>,
git@vger.kernel.org, jsogo@debian.org
Subject: Re: [PATCH] git-svn: don't escape tilde ('~') for http(s) URLs
Date: Wed, 22 Oct 2008 08:13:25 +0200 [thread overview]
Message-ID: <20081022061325.GC8225@glandium.org> (raw)
In-Reply-To: <7vtzb5wr6v.fsf@gitster.siamese.dyndns.org>
On Tue, Oct 21, 2008 at 02:53:28PM -0700, Junio C Hamano wrote:
> Eric Wong <normalperson@yhbt.net> writes:
>
> >> strace revealed that git-svn url-encodes ~ while svn does not do that.
> >>
> >> For svn we have:
> >> write(5, "<S:update-report send-all=\"true\" xmlns:S=\"svn:\">
> >> <S:src-path>https://sucs.org/~welshbyte/svn/backuptool/trunk</S:src-path>...
> >>
> >> While git-svn shows:
> >> write(7, "<S:update-report send-all=\"true\" xmlns:S=\"svn:\">
> >> <S:src-path>https://sucs.org/%7Ewelshbyte/svn/backuptool/trunk</S:src-path>...
>
> This looks like an XML based request sequence to me (and svn is talking
> WebDAV here, right?);
XML based would be &126;, not %7E.
Anyways, aren't there ready-to-use url quoting functions in perl ?
Mike
next prev parent reply other threads:[~2008-10-22 6:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-18 21:39 git-svn url-encodes ~ when it should not Björn Steinbrink
2008-10-18 22:47 ` Björn Steinbrink
2008-10-21 21:12 ` [PATCH] git-svn: don't escape tilde ('~') for http(s) URLs Eric Wong
2008-10-21 21:53 ` Junio C Hamano
2008-10-22 6:13 ` Mike Hommey [this message]
2008-10-22 6:24 ` Junio C Hamano
2008-10-22 8:16 ` Eric Wong
2008-10-22 18:53 ` Junio C Hamano
2008-10-24 9:13 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022061325.GC8225@glandium.org \
--to=mh@glandium.org \
--cc=B.Steinbrink@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jsogo@debian.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).