From: Jeff King <peff@peff.net>
To: Alexander Gavrilov <angavrilov@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] builtin-blame: Reencode commit messages according to git-log rules.
Date: Wed, 22 Oct 2008 04:50:37 -0400 [thread overview]
Message-ID: <20081022085036.GA1454@sigill.intra.peff.net> (raw)
In-Reply-To: <bb6f213e0810220135hd520f78odb83414c248a15e4@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
On Wed, Oct 22, 2008 at 12:35:17PM +0400, Alexander Gavrilov wrote:
> > instead. Of course, I can't get your test to pass even with that change,
> > but I think that is just a broken iconv on Solaris.
>
> Hm, which of the conversions fail? You can try manually converting the
> txt files with the iconv command to figure it out.
Test 2 fails for CP1251 and SJIS. Manually converting with iconv seems
to work ok (at least, doing "iconv -f CP1251 -t UTF-8 cp1251.txt"
produces the same output as "cat utf8.txt".
The output from "t8005-blame-i18n.sh -v -i" is attached (as
application/octet-stream to protect it from email munging) if that is
helpful to you. I can't make heads or tails of it.
-Peff
[-- Attachment #2: t8005-output.txt --]
[-- Type: application/octet-stream, Size: 1787 bytes --]
next prev parent reply other threads:[~2008-10-22 8:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 20:55 [PATCH v2] builtin-blame: Reencode commit messages according to git-log rules Alexander Gavrilov
2008-10-22 8:20 ` Jeff King
2008-10-22 8:35 ` Alexander Gavrilov
2008-10-22 8:50 ` Jeff King [this message]
2008-10-22 9:32 ` Alexander Gavrilov
2008-10-22 12:39 ` Jeff King
2008-10-22 19:07 ` Junio C Hamano
2008-10-22 19:14 ` Jeff King
2008-10-22 19:22 ` Jeff King
2008-10-22 20:29 ` Johannes Schindelin
2008-10-22 20:40 ` Jeff King
2008-10-22 20:12 ` Jakub Narebski
2008-10-22 20:42 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022085036.GA1454@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=angavrilov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).