git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Deskin Miller <deskinm@umich.edu>
To: git@vger.kernel.org
Cc: normalperson@yhbt.net
Subject: [PATCH] git-svn: change dashed git-config to git config
Date: Thu, 23 Oct 2008 15:21:34 -0400	[thread overview]
Message-ID: <20081023192134.GB8320@euler> (raw)

---
When testing git-svn changes, I'll often use git-svn.perl directly on a
repository of mine, to see how things work.  Recently I had this happen:

$ git-svn.perl info
Use of uninitialized value in scalar chomp at ../git/git-svn.perl line 1202.
Use of uninitialized value in concatenation (.) or string at ../git/git-svn.perl line 1203.

but the expected output showed up correctly, giving the SVN-like info.

git svn info appeared to work just fine though, despite there being essentially
no difference between the two.  However, if I do the following, this is what I
see:

$ env /usr/libexec/git-core/git-svn info
Can't exec "git-config": No such file or directory at /usr/libexec/git-core/git-svn line 1202.
Use of uninitialized value in scalar chomp at /usr/libexec/git-core/git-svn line 1202.

Again, the SVN info would still appear.

Regardless, I think we want to change this call to use the non-dashed form.

Deskin Miller
 
 git-svn.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-svn.perl b/git-svn.perl
index 33e1b50..2e68c68 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1126,7 +1126,7 @@ sub read_repo_config {
 		my $v = $opts->{$o};
 		my ($key) = ($o =~ /^([a-zA-Z\-]+)/);
 		$key =~ s/-//g;
-		my $arg = 'git-config';
+		my $arg = 'git config';
 		$arg .= ' --int' if ($o =~ /[:=]i$/);
 		$arg .= ' --bool' if ($o !~ /[:=][sfi]$/);
 		if (ref $v eq 'ARRAY') {
-- 
1.6.0.2.554.g3041b

             reply	other threads:[~2008-10-23 19:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-23 19:21 Deskin Miller [this message]
2008-10-24  9:15 ` [PATCH] git-svn: change dashed git-config to git config Eric Wong
2008-10-24 15:27   ` Deskin Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081023192134.GB8320@euler \
    --to=deskinm@umich.edu \
    --cc=git@vger.kernel.org \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).