From: Clark Williams <clark.williams@gmail.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH stgit] revised patch for importing series from tarball
Date: Thu, 23 Oct 2008 21:53:09 -0500 [thread overview]
Message-ID: <20081023215309.2dc07e6e@gmail.com> (raw)
In-Reply-To: <20081024011708.GA20369@diana.vm.bytemark.co.uk>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Fri, 24 Oct 2008 03:17:08 +0200
Karl Hasselström <kha@treskal.com> wrote:
> On 2008-10-19 14:16:13 -0500, Clark Williams wrote:
>
> > I added a simple test to the test harness for import as well.
>
> Great!
>
> > Oh and I added '*.elc' to the .gitignore file. May not be that many
> > folks using emacs with stgit, but hey, I am! :)
>
> Me too (but I have *.elc in my personal ignore file, so I never saw
> it). However, this is an unrelated change, and we don't need to ignore
> .elc files at the top level, only in contrib. I've taken the liberty
> of splitting this out to a separate commit and forging your signature
> on it -- let me know if that's OK and I'll push it out.
>
Yes, that's fine.
> > patch to allow importing a series from a tar archive
>
> I turned this into a complete sentence, and removed "patch" since it's
> entirely redundant.
>
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -6,3 +6,4 @@ patches-*
> > release.sh
> > setup.cfg.rpm
> > snapshot.sh
> > +*.elc
>
> As I said, I put this in a separate patch, and put that ignore pattern
> in contrib.gitignore instead.
>
Thanks
> > make_option('--commemail',
> > - help = 'use COMMEMAIL as the committer e-mail')
> > + help = 'use COMMEMAIL as the committer e-mail'),
> > ] + make_sign_options()
>
> This is just a noise change _and_ didn't apply, so I dropped it.
>
Agreed.
Thanks for the update.
Clark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
iEYEARECAAYFAkkBOJ0ACgkQqA4JVb61b9e6SgCeOZ0YrB/uSrvSqgLkxnLjiQp2
AWwAoKIeIQUOWEghEOWBgODnTojA2o5q
=B9dz
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2008-10-24 2:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-19 19:16 [PATCH stgit] revised patch for importing series from tarball Clark Williams
2008-10-24 1:17 ` Karl Hasselström
2008-10-24 2:53 ` Clark Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081023215309.2dc07e6e@gmail.com \
--to=clark.williams@gmail.com \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).