From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Junio C Hamano <junio@pobox.com>
Subject: Re: [PATCH] add -p: warn if only binary changes present
Date: Sun, 26 Oct 2008 11:40:06 +0100 [thread overview]
Message-ID: <20081026104006.GA18969@neumann> (raw)
In-Reply-To: <200810261128.14735.trast@student.ethz.ch>
On Sun, Oct 26, 2008 at 12:28:09PM +0200, Thomas Rast wrote:
> Jeff King wrote:
> > > + print STDERR "No changes except to binary files.\n";
> > No changed text files.
> I tried to make a more precise statement. "No changed text files"
> also holds if no files at all were changed. A user can only infer
> that there _are_ binary changes if he knows that the message in the
> latter case would have been "No changes".
>
> That being said, it is somewhat awkward, I just couldn't come up with
> a better message with this meaning.
What about
Only binary files changed.
or something of the sort?
Gábor
next prev parent reply other threads:[~2008-10-26 10:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 21:48 [PATCH] add -p: warn if only binary changes present Thomas Rast
2008-10-26 5:10 ` Jeff King
2008-10-26 10:28 ` Thomas Rast
2008-10-26 10:40 ` SZEDER Gábor [this message]
2008-10-26 19:37 ` [PATCH v2] " Thomas Rast
2008-10-26 19:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081026104006.GA18969@neumann \
--to=szeder@ira.uka.de \
--cc=git@vger.kernel.org \
--cc=junio@pobox.com \
--cc=peff@peff.net \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).