From: Jeff King <peff@peff.net>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
"René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Subject: Re: [PATCH 1/2] Add --verbose|-v to test-chmtime
Date: Thu, 30 Oct 2008 18:58:51 -0400 [thread overview]
Message-ID: <20081030225850.GA3688@sigill.intra.peff.net> (raw)
In-Reply-To: <81b0412b0810300426u2ccbe51at1bf5f989b6333ed1@mail.gmail.com>
On Thu, Oct 30, 2008 at 12:26:24PM +0100, Alex Riesen wrote:
> This allows us replace perl when getting the mtime of a file because
> of time zone conversions, though at the moment only one platform which
> does this has been identified: Cygwin when used with ActiveState Perl
> (as usual).
> [...]
> test-chmtime -v +0 filename1 | cut -f 1
Personally, I would have:
- split the argument refactoring and the addition of the "-v" argument
into two patches to make reviewers lives easier
- just used a special timespec that means "don't change anything, but
show show"
but I think those are mostly nitpicks, so I am OK with the series as-is.
-Peff
prev parent reply other threads:[~2008-10-30 23:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 11:26 [PATCH 1/2] Add --verbose|-v to test-chmtime Alex Riesen
2008-10-30 22:58 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081030225850.GA3688@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raa.lkml@gmail.com \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).