git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Hilt <ian.hilt@gmx.com>
To: Brian Gernhardt <benji@silverinsanity.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] t4030: Don't use echo -n
Date: Thu, 30 Oct 2008 19:52:15 -0400	[thread overview]
Message-ID: <20081030235215.GB18221@sys-0.hiltweb.site> (raw)
In-Reply-To: <1225404776-51748-1-git-send-email-benji@silverinsanity.com>

On Thu, Oct 30, 2008 at 06:12:56PM -0400, Brian Gernhardt wrote:
> Signed-off-by: Brian Gernhardt <benji@silverinsanity.com>

No commit message???

> ---
>  t/t4030-diff-textconv.sh |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/t/t4030-diff-textconv.sh b/t/t4030-diff-textconv.sh
> index 3945731..7ec244f 100755
> --- a/t/t4030-diff-textconv.sh
> +++ b/t/t4030-diff-textconv.sh
> @@ -96,16 +96,15 @@ cat >expect.typechange <<'EOF'
>  -1
>  diff --git a/file b/file
>  new file mode 120000
> -index ad8b3d2..67be421
> +index ad8b3d2..8e4020b
>  --- /dev/null
>  +++ b/file
>  @@ -0,0 +1 @@
>  +frotz
> -\ No newline at end of file
>  EOF
>  # make a symlink the hard way that works on symlink-challenged file systems
>  test_expect_success 'textconv does not act on symlinks' '
> -	echo -n frotz > file &&
> +	echo frotz > file &&
>  	git add file &&
>  	git ls-files -s | sed -e s/100644/120000/ |
>  		git update-index --index-info &&
> -- 
> 1.6.0.3.523.g304d0

This doesn't apply for me.  My tip is up-to-date, but it doesn't even have
this file it t/.

A little bewildered,

	Ian

  reply	other threads:[~2008-10-31  0:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30 22:12 [PATCH] t4030: Don't use echo -n Brian Gernhardt
2008-10-30 23:52 ` Ian Hilt [this message]
2008-10-31  5:02   ` Brian Gernhardt
2008-10-31  5:09     ` [PATCH] Avoid using non-portable `echo -n` in tests Brian Gernhardt
2008-10-31  8:15       ` Junio C Hamano
2008-10-31 15:38         ` Brian Gernhardt
2008-10-31  8:20       ` Junio C Hamano
2008-10-31  9:36         ` [PATCH] Avoid using non-portable `echo-n` " Steve Folly
2008-10-31 14:32       ` [PATCH] Avoid using non-portable `echo -n` " Shawn O. Pearce
2008-10-31 18:24       ` Jeff King
2008-10-31 18:36         ` Pierre Habouzit
2008-10-31 18:39           ` Jeff King
2008-10-31 19:35             ` Francis Galiegue
2008-10-31 22:53               ` Johannes Schindelin
2008-11-03 16:30         ` Mike Ralphson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081030235215.GB18221@sys-0.hiltweb.site \
    --to=ian.hilt@gmx.com \
    --cc=benji@silverinsanity.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).