From: Deskin Miller <deskinm@umich.edu>
To: git@vger.kernel.org
Cc: normalperson@yhbt.net, gitster@pobox.com
Subject: [PATCH] git-svn: change dashed git-commit-tree to git commit-tree
Date: Fri, 31 Oct 2008 00:10:25 -0400 [thread overview]
Message-ID: <20081031041025.GB20322@euler> (raw)
Signed-off-by: Deskin Miller <deskinm@umich.edu>
---
Once again I'm using a copy of git-svn.perl directly, and this fails to exec.
I looked at it more closely and it fails because git binary calls setup_path,
which puts the libexec path into $PATH; of course, this doesn't happen when
git-svn is called directly.
git-svn.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 2e68c68..56238da 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -2202,7 +2202,7 @@ sub do_git_commit {
}
die "Tree is not a valid sha1: $tree\n" if $tree !~ /^$::sha1$/o;
- my @exec = ('git-commit-tree', $tree);
+ my @exec = ('git', 'commit-tree', $tree);
foreach ($self->get_commit_parents($log_entry)) {
push @exec, '-p', $_;
}
--
1.6.0.3.515.g304f
next reply other threads:[~2008-10-31 4:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 4:10 Deskin Miller [this message]
2008-11-02 9:38 ` [PATCH] git-svn: change dashed git-commit-tree to git commit-tree Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081031041025.GB20322@euler \
--to=deskinm@umich.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).