From: Jeff King <peff@peff.net>
To: Brian Gernhardt <benji@silverinsanity.com>
Cc: Git List <git@vger.kernel.org>, Shawn O Pearce <spearce@spearce.org>
Subject: Re: [PATCH] Avoid using non-portable `echo -n` in tests.
Date: Fri, 31 Oct 2008 14:24:56 -0400 [thread overview]
Message-ID: <20081031182456.GC3230@sigill.intra.peff.net> (raw)
In-Reply-To: <1225429753-70109-1-git-send-email-benji@silverinsanity.com>
On Fri, Oct 31, 2008 at 01:09:13AM -0400, Brian Gernhardt wrote:
> Not all /bin/sh have a builtin echo that recognizes -n. Using printf
> is far more portable.
>
> Discovered on OS X 10.5.5 in t4030-diff-textconv.sh and changed in all
> the test scripts.
Hmph. I think this is a good patch, and there is precedent in the past
(20fa04ea, 2aad957, 9754563). But I am surprised this was not caught by
our recent autobuilding project.
However, it seems to work on FreeBSD (which makes it doubly weird that
it is broken on OS X). On Solaris, the /bin/sh is so horribly broken
that I have to use bash anyway. Commit 9754563 claims breakage on AIX,
but it looks like Mike is doing the AIX builds with bash.
So I guess we just need an OS X autobuild. ;)
> t/t4030-diff-textconv.sh | 2 +-
And of course this one was me, but I blame JSixt, whose test I just
mindlessly copied. ;)
-Peff
next prev parent reply other threads:[~2008-10-31 18:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 22:12 [PATCH] t4030: Don't use echo -n Brian Gernhardt
2008-10-30 23:52 ` Ian Hilt
2008-10-31 5:02 ` Brian Gernhardt
2008-10-31 5:09 ` [PATCH] Avoid using non-portable `echo -n` in tests Brian Gernhardt
2008-10-31 8:15 ` Junio C Hamano
2008-10-31 15:38 ` Brian Gernhardt
2008-10-31 8:20 ` Junio C Hamano
2008-10-31 9:36 ` [PATCH] Avoid using non-portable `echo-n` " Steve Folly
2008-10-31 14:32 ` [PATCH] Avoid using non-portable `echo -n` " Shawn O. Pearce
2008-10-31 18:24 ` Jeff King [this message]
2008-10-31 18:36 ` Pierre Habouzit
2008-10-31 18:39 ` Jeff King
2008-10-31 19:35 ` Francis Galiegue
2008-10-31 22:53 ` Johannes Schindelin
2008-11-03 16:30 ` Mike Ralphson
-- strict thread matches above, loose matches on Subject: below --
2008-10-31 19:50 Francis Galiegue
2008-10-31 20:10 ` Junio C Hamano
2008-10-31 20:11 ` Ian Hilt
2008-10-31 20:30 ` Francis Galiegue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081031182456.GC3230@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=benji@silverinsanity.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).