From: Jeff King <peff@peff.net>
To: Pierre Habouzit <madcoder@debian.org>
Cc: Brian Gernhardt <benji@silverinsanity.com>,
Git List <git@vger.kernel.org>,
Shawn O Pearce <spearce@spearce.org>
Subject: Re: [PATCH] Avoid using non-portable `echo -n` in tests.
Date: Fri, 31 Oct 2008 14:39:33 -0400 [thread overview]
Message-ID: <20081031183933.GA3577@sigill.intra.peff.net> (raw)
In-Reply-To: <20081031183601.GB8464@artemis.corp>
On Fri, Oct 31, 2008 at 07:36:01PM +0100, Pierre Habouzit wrote:
> Set up a Debian autobuilder with dash as a /bin/sh (apt-get install
> dash, dpkg-reconfigure -plow dash and say 'yes'). You'll see those kind
> of problems arise immediately.
I don't need to; my development box is Debian with dash as /bin/sh. :)
> Dash is a POSIX compatible shell, with almost no extension added (in
> particular its echo has no -n option) which helps to find those kind of
> issues.
>
> It would help detecting git shell scripts that use bashism as well.
Agreed, and actually I found such a bashism (test ==) last week (though
of course it also broke on FreeBSD).
-Peff
next prev parent reply other threads:[~2008-10-31 18:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 22:12 [PATCH] t4030: Don't use echo -n Brian Gernhardt
2008-10-30 23:52 ` Ian Hilt
2008-10-31 5:02 ` Brian Gernhardt
2008-10-31 5:09 ` [PATCH] Avoid using non-portable `echo -n` in tests Brian Gernhardt
2008-10-31 8:15 ` Junio C Hamano
2008-10-31 15:38 ` Brian Gernhardt
2008-10-31 8:20 ` Junio C Hamano
2008-10-31 9:36 ` [PATCH] Avoid using non-portable `echo-n` " Steve Folly
2008-10-31 14:32 ` [PATCH] Avoid using non-portable `echo -n` " Shawn O. Pearce
2008-10-31 18:24 ` Jeff King
2008-10-31 18:36 ` Pierre Habouzit
2008-10-31 18:39 ` Jeff King [this message]
2008-10-31 19:35 ` Francis Galiegue
2008-10-31 22:53 ` Johannes Schindelin
2008-11-03 16:30 ` Mike Ralphson
-- strict thread matches above, loose matches on Subject: below --
2008-10-31 19:50 Francis Galiegue
2008-10-31 20:10 ` Junio C Hamano
2008-10-31 20:11 ` Ian Hilt
2008-10-31 20:30 ` Francis Galiegue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081031183933.GA3577@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=benji@silverinsanity.com \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).