From: Eric Wong <normalperson@yhbt.net>
To: Deskin Miller <deskinm@umich.edu>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] git-svn: change dashed git-commit-tree to git commit-tree
Date: Sun, 2 Nov 2008 01:38:58 -0800 [thread overview]
Message-ID: <20081102093858.GA16003@untitled> (raw)
In-Reply-To: <20081031041025.GB20322@euler>
Deskin Miller <deskinm@umich.edu> wrote:
> Signed-off-by: Deskin Miller <deskinm@umich.edu>
> ---
> Once again I'm using a copy of git-svn.perl directly, and this fails to exec.
> I looked at it more closely and it fails because git binary calls setup_path,
> which puts the libexec path into $PATH; of course, this doesn't happen when
> git-svn is called directly.
Thanks Deskin, looks like Junio already picked it up; but if we had
git-notes I'd add my Signed-off-by there :)
Also, on the subject of using git-svn.perl directly from the source
tree, it may become less usable that way in the near future:
Most of us (myself included) at GitTogether seemed like the idea of
splitting git-svn.perl into multiple files for maintainability reasons.
I just haven't gotten around to doing it yet.
OTOH, Git.pm is already required (but likely also installed in your
normal load paths); so you may just have to remember to use perl -I
--
Eric Wong
prev parent reply other threads:[~2008-11-02 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 4:10 [PATCH] git-svn: change dashed git-commit-tree to git commit-tree Deskin Miller
2008-11-02 9:38 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081102093858.GA16003@untitled \
--to=normalperson@yhbt.net \
--cc=deskinm@umich.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).