From: Jakub Narebski <jnareb@gmail.com>
To: Alexander Gavrilov <angavrilov@gmail.com>
Cc: git@vger.kernel.org,
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>,
Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCH] gitweb: Fix mod_perl support.
Date: Wed, 5 Nov 2008 23:40:26 +0100 [thread overview]
Message-ID: <200811052340.27677.jnareb@gmail.com> (raw)
In-Reply-To: <200811060110.07965.angavrilov@gmail.com>
Alexander Gavrilov wrote:
> [...] it is necessary to declare all global
> variables as 'our' [...]
>
> Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
I have forgot about that when reviewing path_info patches. I'm sorry
about that. Good catch, and good explanation.
Acked-by: Jakub Narebski <jnareb@gmail.com>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index c5254af..2174d4a 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
[...]
> -my $path_info = $ENV{"PATH_INFO"};
> +our $path_info = $ENV{"PATH_INFO"};
[...]
--
Jakub Narebski
Poland
prev parent reply other threads:[~2008-11-05 22:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 22:10 [PATCH] gitweb: Fix mod_perl support Alexander Gavrilov
2008-11-05 22:40 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811052340.27677.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=angavrilov@gmail.com \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox