git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH (GIT-GUI)] git-gui: Request blame metadata in utf-8.
@ 2008-11-09 15:53 Alexander Gavrilov
  2008-11-11 17:35 ` Shawn O. Pearce
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Gavrilov @ 2008-11-09 15:53 UTC (permalink / raw)
  To: git; +Cc: Shawn O. Pearce

The blame builtin now supports automatic conversion of
metadata encoding. By default it is converted to the
character set specified by i18n.logoutputencoding.

Since gui blame expects the data in utf-8, it is
necessary to specify the desired encoding directly.
An old version of the blame command will simply
ignore the option.

Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
---
 lib/blame.tcl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/blame.tcl b/lib/blame.tcl
index 8d60f12..4875804 100644
--- a/lib/blame.tcl
+++ b/lib/blame.tcl
@@ -559,7 +559,7 @@ method _read_file {fd jump} {
 } ifdeleted { catch {close $fd} }
 
 method _exec_blame {cur_w cur_d options cur_s} {
-	lappend options --incremental
+	lappend options --incremental --encoding=utf-8
 	if {$commit eq {}} {
 		lappend options --contents $path
 	} else {
-- 
1.6.0.3.15.gb8d36

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH (GIT-GUI)] git-gui: Request blame metadata in utf-8.
  2008-11-09 15:53 [PATCH (GIT-GUI)] git-gui: Request blame metadata in utf-8 Alexander Gavrilov
@ 2008-11-11 17:35 ` Shawn O. Pearce
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn O. Pearce @ 2008-11-11 17:35 UTC (permalink / raw)
  To: Alexander Gavrilov; +Cc: git

Alexander Gavrilov <angavrilov@gmail.com> wrote:
> The blame builtin now supports automatic conversion of
> metadata encoding. By default it is converted to the
> character set specified by i18n.logoutputencoding.
> 
> Since gui blame expects the data in utf-8, it is
> necessary to specify the desired encoding directly.
> An old version of the blame command will simply
> ignore the option.

Thanks; all 3 applied.
 
-- 
Shawn.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-11-11 17:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-09 15:53 [PATCH (GIT-GUI)] git-gui: Request blame metadata in utf-8 Alexander Gavrilov
2008-11-11 17:35 ` Shawn O. Pearce

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).