git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Tell users that git protocol is not for pushing
@ 2008-11-11  5:06 Nathan W. Panike
  2008-11-11  7:24 ` Alex Riesen
  0 siblings, 1 reply; 2+ messages in thread
From: Nathan W. Panike @ 2008-11-11  5:06 UTC (permalink / raw)
  To: git; +Cc: Nathan W. Panike

When one attempts to push to a git-protocol repository, one gets the
line:

fatal: The remote end hung up unexpectedly

This seems a bit obscure to me.  It is better to inform the user that git://
does not allow pushing.
---
 transport.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/transport.c b/transport.c
index 56831c5..2c1577e 100644
--- a/transport.c
+++ b/transport.c
@@ -684,7 +684,9 @@ static int git_transport_push(struct transport *transport, int refspec_nr, const
 	args.use_thin_pack = data->thin;
 	args.verbose = !!(flags & TRANSPORT_PUSH_VERBOSE);
 	args.dry_run = !!(flags & TRANSPORT_PUSH_DRY_RUN);
-
+	if(strncmp(transport->url,"git",3)==0){
+		fprintf(stderr,"git protocol does not support push.\n");
+	}
 	return send_pack(&args, transport->url, transport->remote, refspec_nr, refspec);
 }
 
-- 
1.6.0.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Tell users that git protocol is not for pushing
  2008-11-11  5:06 [PATCH] Tell users that git protocol is not for pushing Nathan W. Panike
@ 2008-11-11  7:24 ` Alex Riesen
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Riesen @ 2008-11-11  7:24 UTC (permalink / raw)
  To: Nathan W. Panike; +Cc: git

Nathan W. Panike, Tue, Nov 11, 2008 06:06:16 +0100:
> When one attempts to push to a git-protocol repository, one gets the
> line:
> 
> fatal: The remote end hung up unexpectedly
> 
> This seems a bit obscure to me.  It is better to inform the user that git://
> does not allow pushing.

But it does. See git daemon --help, look for receive-pack.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-11-11  7:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-11  5:06 [PATCH] Tell users that git protocol is not for pushing Nathan W. Panike
2008-11-11  7:24 ` Alex Riesen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).