From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H.Merijn Brand" Subject: Re: Install issues Date: Tue, 11 Nov 2008 08:59:23 +0100 Message-ID: <20081111085923.00213a89@pc09.procura.nl> References: <20081110121739.15f77a01@pc09.procura.nl> <20081110113924.GR24201@genesis.frugalware.org> <20081110173101.3d76613b@pc09.procura.nl> <20081110175123.GV24201@genesis.frugalware.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: git@vger.kernel.org To: Miklos Vajna X-From: git-owner@vger.kernel.org Tue Nov 11 09:01:00 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1KzoBI-0002Jc-9N for gcvg-git-2@gmane.org; Tue, 11 Nov 2008 09:01:00 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752593AbYKKH7p (ORCPT ); Tue, 11 Nov 2008 02:59:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751884AbYKKH7p (ORCPT ); Tue, 11 Nov 2008 02:59:45 -0500 Received: from smtp-vbr9.xs4all.nl ([194.109.24.29]:2715 "EHLO smtp-vbr9.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751767AbYKKH7o (ORCPT ); Tue, 11 Nov 2008 02:59:44 -0500 Received: from pc09.procura.nl (procura.xs4all.nl [82.95.216.29]) (authenticated bits=0) by smtp-vbr9.xs4all.nl (8.13.8/8.13.8) with ESMTP id mAB7xOg3045674 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 11 Nov 2008 08:59:30 +0100 (CET) (envelope-from h.m.brand@xs4all.nl) In-Reply-To: <20081110175123.GV24201@genesis.frugalware.org> X-Mailer: Claws Mail 3.6.1cvs12 (GTK+ 2.12.0; x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwEAIAAACI8LKTAAAACXBIWXMAAABIAAAASABGyWs+AAAC JElEQVRo3u2aMY4CMQxFczZ6RItEzRm4DBINDbRUSPRInIRbsNK6+dJfezN4kokn48IaCSjysL8d e9Knoj2fr9f9/gllqQ6U9/vxWK3EdwdIEGjRIVCu18NhuxUfK46SH81+fzrdbuKPx/P5ctHQdAdI TKAgpvV6s9ntBEfXEYSGgMQzIHnuFBBjkshCNJ2KtJZ04hHNAugP8bZr3NIHhbcF0AKoK0CoaHXU LUWBIs1n+jV+Fl8CVqOApEXAwyMO/DSR4XVntoAYDR7eBjQupuYAYTMph8Rj21D4m7MChN02tpqs NSnb/KqU2oHCXu5xDCgflj/RAgBiKBIXnICzAsSjWBsTz5K4/HeXYvb8yK5lY3VGEwPi2aONKT+5 AlcxrTPOwcTiraGRChgMEKJh0bVVifGVTq6qgBiNVl8QE29EsK6VE+YJAOG2wz5AvsqUS6uqgHCA n4NGvBYpnJ64Jgg27sCtxtBk1CJIA4S/GhdWKh07QxUB48jWGhZ4jKamRRr/T8/M0AaEyctry6YB 4dTGj9iWZNs3DahES5kPCJOu0RQbF/fQOBprsB9gaO9JtPDzII9U5ySXX7AnuIt91y54AAW7rPpT LCe5gt3F+CLqr2UarGB3MXvMylWGq4+9RCx3TW1oJq1t3HPQlFs6N1fFNEB4s8dn7Ne7ACSm7TPQ I5quAWmw6qBpulHM33B0Csge4Nd8JTTYG2b1XyRe3lH8x34ABJ6aePuQ2N4AAAAASUVORK5CYII= X-Virus-Scanned: by XS4ALL Virus Scanner Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Mon, 10 Nov 2008 18:51:23 +0100, Miklos Vajna wrote: > On Mon, Nov 10, 2008 at 05:31:01PM +0100, "H.Merijn Brand" wrote: > > --- Makefile.org 2008-11-10 17:29:53.000000000 +0100 > > +++ Makefile 2008-11-10 17:29:39.000000000 +0100 > > @@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X > > ./test-sha1.sh > > > > check: common-cmds.h > > + @`sparse /dev/null` || (\ > > + echo "The 'sparse' command is not available, so I cannot make the 'check' target" ;\ > > + echo "Did you mean 'make test' instead?" ;\ > > + exit 1 ) > > for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done > > Please read Documentation/SubmittingPatches, your patch lacks a signoff > and a commit message. You're not making things easier for people that do not use git from a git repo, something that happens quite a lot when you build from a released tarball. git-1.6.0.4 $ git format-patch -M fatal: Not a git repository Exit 128 I don't like this at all. How much more work is it for you to add the subject and sign-off yourself, instead of requiring that from people that like to help? In the perl development, the only thing we *require* is a diff that either uses unified (preferred) or context diff. I did follow the ideal patch flow so far: --8<--- An ideal patch flow Here is an ideal patch flow for this project the current maintainer suggests to the contributors: (0) You come up with an itch. You code it up. (1) Send it to the list and cc people who may need to know about the change. -->8--- Code speaks louder than words, so I proposed a patch. This might be my last patch. git is not just another project I want to loose so much time in. --8<--- Author: H.Merijn Brand Date: Mon, 10 Nov 2008 17:31:01 +0100 Make check needs sparse. If sparse is not available, it might as well be a user error who really wanted make test. Signed-off-by: H.Merijn Brand --- diff --git a/Makefile.org b/Makefile index becd008..718ddf2 100644 --- a/Makefile +++ b/Makefile @@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X ./test-sha1.sh check: common-cmds.h + @`sparse /dev/null` || (\ + echo "The 'sparse' command is not available, so I cannot make the 'check' target" ;\ + echo "Did you mean 'make test' instead?" ;\ + exit 1 ) for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done remove-dashes: -->8--- -- H.Merijn Brand Amsterdam Perl Mongers http://amsterdam.pm.org/ using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00, 11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin. http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/