From: "Shawn O. Pearce" <spearce@spearce.org>
To: Raimund Bauer <ray007@gmx.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Francis Galiegue <fg@one2team.net>,
Git Mailing List <git@vger.kernel.org>,
Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Subject: Re: JGIT: discuss: diff/patch implementation
Date: Tue, 11 Nov 2008 09:18:16 -0800 [thread overview]
Message-ID: <20081111171816.GK2932@spearce.org> (raw)
In-Reply-To: <1226398000.7541.11.camel@minastirith.xtradesoft.lan>
Raimund Bauer <ray007@gmx.net> wrote:
> On Mon, 2008-11-10 at 12:50 -0800, Junio C Hamano wrote:
> > Francis Galiegue <fg@one2team.net> writes:
> >
> > > A very nice git feature, without even going as far as merges, is the cherry
> > > pick feature.
> >
> > I thought cherry-picking needs to be done in terms of 3-way merge, not
> > diff piped to patch, for correctness's sake.
>
> What about http://sourceforge.net/projects/jlibdiff ?
> Maybe a bit old, but claims to have diff3 and is under LGPL.
I hadn't looked at that library before.
We've generally tried to avoid LGPL diff implementations, but partly
because any I found were ports from a GPL C based code tree to Java,
but then the guy who did the port went and changed the license
to LGPL. Slightly dubious if you ask me. ;-)
LGPL plays nicely with BSD, especially in Java where runtime
relinking is possible. But it does screw with jgit.pgm's little
idea of "shove *everything* into a single shell script", as then
its not runtime re-linkable by the user.
I don't know how the Eclipse foundation feels about distributing
LGPL in the IDE. One of our major reasons for going with a BSD
license on JGit was so the Eclipse Git team provider plugin could be
distributed alongside the CVS team provider, as part of the basic IDE
team provider package. We're clearly not ready for that wide of a
distribution, but it was a goal Robin and I set out for the project.
--
Shawn.
next prev parent reply other threads:[~2008-11-11 17:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 14:22 JGIT: discuss: diff/patch implementation Francis Galiegue
2008-11-10 15:56 ` Robin Rosenberg
2008-11-10 16:16 ` Francis Galiegue
2008-11-10 16:59 ` Robin Rosenberg
2008-11-10 18:11 ` Francis Galiegue
2008-11-10 19:46 ` Johannes Schindelin
2008-11-10 20:21 ` Francis Galiegue
2008-11-10 20:50 ` Junio C Hamano
2008-11-10 20:52 ` Shawn O. Pearce
2008-11-10 21:31 ` Francis Galiegue
2008-11-10 23:37 ` Johannes Schindelin
2008-11-11 10:06 ` Raimund Bauer
2008-11-11 17:18 ` Shawn O. Pearce [this message]
2008-11-11 17:31 ` Sverre Rabbelier
2008-11-11 7:27 ` Rogan Dawes
2008-11-11 17:13 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081111171816.GK2932@spearce.org \
--to=spearce@spearce.org \
--cc=fg@one2team.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ray007@gmx.net \
--cc=robin.rosenberg.lists@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).