git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Constantine Plotnikov <constantine.plotnikov@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Possible bug: "git log" ignores "--encoding=UTF-8" option if --pretty=format:%e%n%s%n is used
Date: Wed, 12 Nov 2008 06:26:54 -0500	[thread overview]
Message-ID: <20081112112654.GA20640@coredump.intra.peff.net> (raw)
In-Reply-To: <85647ef50811120311q7bc5451x7c084fd2a7864177@mail.gmail.com>

[re-adding list to the cc]

On Wed, Nov 12, 2008 at 02:11:46PM +0300, Constantine Plotnikov wrote:

> > I don't actually use any encodings except UTF-8, so maybe there is some
> > subtle reason not to do so that I don't understand, but I would have
> > expected all of the format placeholders to respect any --encoding
> > parameter.
> >
> Even if this is the bug, it would be better to leave the old behavior
> for backward compatibility reasons and introduce new placeholders.
> Currently tools have to decode messages according to the commit
> encoding, and changing behavior of options will break these tools
> that have implemented workaround for this problem.

Are there such tools? I assumed they would have complained about this as
a bug before writing their own encoding conversion tools. And this is,
AFAIK, the first bug report.

I don't mind playing it safe to avoid breaking other people's tools, but
I'm also not excited about adding a second, "respect encoding" version
of many placeholders (and it's not just %s and %b; I think you would
need author and committer names and emails, too).

-Peff

  parent reply	other threads:[~2008-11-12 11:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-11 19:12 Possible bug: "git log" ignores "--encoding=UTF-8" option if --pretty=format:%e%n%s%n is used Constantine Plotnikov
2008-11-12 10:43 ` Jeff King
     [not found]   ` <85647ef50811120311q7bc5451x7c084fd2a7864177@mail.gmail.com>
2008-11-12 11:26     ` Jeff King [this message]
2008-11-12 13:08       ` Constantine Plotnikov
2008-11-13  1:38         ` Junio C Hamano
2008-11-13  4:34           ` Jeff King
2008-11-13  5:10             ` Junio C Hamano
2008-11-13  5:48               ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081112112654.GA20640@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=constantine.plotnikov@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).