From: Fedor Sergeev <Fedor.Sergeev@Sun.COM>
To: Junio C Hamano <gitster@pobox.com>
Cc: Roman.Shaposhnick@Sun.COM, git@vger.kernel.org
Subject: Re: overly smart rebase - bug or feature?
Date: Thu, 13 Nov 2008 00:39:21 +0300 [thread overview]
Message-ID: <20081112213920.GB5018@sun.com> (raw)
In-Reply-To: <7vod0n41i5.fsf@gitster.siamese.dyndns.org>
On Mon, Nov 10, 2008, Junio C Hamano wrote:
> Fedor Sergeev <Fedor.Sergeev@Sun.COM> writes:
> >> You might be able to work this around by forcing rebase not to use the
> >> simplified 3-way merge, by saying "rebase -m".
> >
> > Yeah, it worked.
> > ...
> > CONFLICT (delete/modify): Makefile deleted in master and modified in HEAD~0. Version HEAD~0 of Makefile left in tree.
> > ...
> >
> > Though it does make me wonder why *simplified* 3-way merge is smarter than git merge ;)))
>
> Simplified one is not _smarter_. It is merely _faster_, exactly because
> it only looks at the paths between A^..A and nothing else.
I seem to start getting grasp on it.
Please, correct me if I'm wrong:
- by default rebase uses "simplified" merge, which (roughly speaking)
simply goes around patching parent with changes from either branches A and B
- rebase -m applies 'recursive' merge (default merge strategy) which is
kind of smarter and determines a conflict in my case
- literally the same happens when I do merge instead of rebase
- cherry-pick fails just because "patch B" can not apply to A and that is
literally why rebase started falling out to *some* merge first hand
If the above is true then can you, please, answer the following questions:
- is there any merge strategy that can do "simplified" merge just like that in rebase?
(not that I need it, but just for educational purpose)
- does rebase perform simplified merge only because of speed considerations?
(e.g. are there any correctness/usability issues with using smarter merge algo on rebase)
- is there any .git/config variable that affects which merge to use upon rebase?
best regards,
Fedor.
next prev parent reply other threads:[~2008-11-12 21:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 21:23 overly smart rebase - bug or feature? Fedor Sergeev
2008-11-10 23:14 ` Junio C Hamano
2008-11-10 23:31 ` Avery Pennarun
2008-11-10 23:36 ` Fedor Sergeev
2008-11-10 23:57 ` Junio C Hamano
2008-11-12 21:39 ` Fedor Sergeev [this message]
2008-11-12 22:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081112213920.GB5018@sun.com \
--to=fedor.sergeev@sun.com \
--cc=Roman.Shaposhnick@Sun.COM \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).