* [PATCH (GITK)] gitk: Add a menu option to start Git Gui.
@ 2008-11-13 20:12 Alexander Gavrilov
2008-11-18 9:33 ` Paul Mackerras
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Gavrilov @ 2008-11-13 20:12 UTC (permalink / raw)
To: git; +Cc: Paul Mackerras
Git Gui already has menu commands to start gitk,
and this makes the relation symmetric. Since gitk and
git-gui complement each other, I think that it is
beneficial to integrate them where it makes sense.
Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
---
gitk | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/gitk b/gitk
index 46896a2..e4562d7 100755
--- a/gitk
+++ b/gitk
@@ -1906,6 +1906,9 @@ proc makewindow {} {
{mc "Reload" command reloadcommits -accelerator Meta1-F5}
{mc "Reread references" command rereadrefs}
{mc "List references" command showrefs -accelerator F2}
+ {xx "" separator}
+ {mc "Start Git Gui" command {exec git gui &}}
+ {xx "" separator}
{mc "Quit" command doquit -accelerator Meta1-Q}
}}
{mc "Edit" cascade {
--
1.6.0.3.15.gb8d36
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH (GITK)] gitk: Add a menu option to start Git Gui.
2008-11-13 20:12 [PATCH (GITK)] gitk: Add a menu option to start Git Gui Alexander Gavrilov
@ 2008-11-18 9:33 ` Paul Mackerras
2008-11-18 14:12 ` Alexander Gavrilov
0 siblings, 1 reply; 3+ messages in thread
From: Paul Mackerras @ 2008-11-18 9:33 UTC (permalink / raw)
To: Alexander Gavrilov; +Cc: git
Alexander Gavrilov writes:
> Git Gui already has menu commands to start gitk,
> and this makes the relation symmetric. Since gitk and
> git-gui complement each other, I think that it is
> beneficial to integrate them where it makes sense.
I think it makes more sense to have this as an item on the context
menu for the fake commit(s) for local changes.
Paul.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH (GITK)] gitk: Add a menu option to start Git Gui.
2008-11-18 9:33 ` Paul Mackerras
@ 2008-11-18 14:12 ` Alexander Gavrilov
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Gavrilov @ 2008-11-18 14:12 UTC (permalink / raw)
To: Paul Mackerras; +Cc: git
On Tue, Nov 18, 2008 at 12:33 PM, Paul Mackerras <paulus@samba.org> wrote:
> Alexander Gavrilov writes:
>> Git Gui already has menu commands to start gitk,
>> and this makes the relation symmetric. Since gitk and
>> git-gui complement each other, I think that it is
>> beneficial to integrate them where it makes sense.
>
> I think it makes more sense to have this as an item on the context
> menu for the fake commit(s) for local changes.
Git Gui is useful for a lot more things than just committing changes,
e.g. you can interact with remote repositories, or do a merge, or
amend the last commit message. Also, not everyone has local change
display enabled in gitk.
Alexander
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-11-18 14:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-13 20:12 [PATCH (GITK)] gitk: Add a menu option to start Git Gui Alexander Gavrilov
2008-11-18 9:33 ` Paul Mackerras
2008-11-18 14:12 ` Alexander Gavrilov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).