From: Francis Galiegue <fg@one2team.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Sam Vilain <sam@vilain.net>, Francis Galiegue <fge@one2team.com>,
git@vger.kernel.org
Subject: Re: [PATCH] sha1_file: make sure correct error is propagated
Date: Fri, 14 Nov 2008 20:09:51 +0100 [thread overview]
Message-ID: <200811142009.51803.fg@one2team.com> (raw)
In-Reply-To: <7vfxlu9lhs.fsf@gitster.siamese.dyndns.org>
Le Friday 14 November 2008 20:05:19 Junio C Hamano, vous avez écrit :
[...]
> > fd = mkstemp(buffer);
> > - if (fd < 0 && dirlen && (errno != EPERM)) {
> > + if (fd < 0 && dirlen && (errno != EACCESS)) {
>
> Is this accepting the two as equivalents???
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Well, looking at mkdir(2), it says:
EPERM The file system containing pathname does not support the
creation of directories.
Hmm, err... git would fail at an earlier point anyway, wouldn't it? Even git
init would fail there.
--
Francis Galiegue
ONE2TEAM
Ingénieur système
Mob : +33 (0) 6 83 87 78 75
Tel : +33 (0) 1 78 94 55 52
fge@one2team.com
40 avenue Raymond Poincaré
75116 Paris
next prev parent reply other threads:[~2008-11-14 19:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 7:19 [PATCH] sha1_file: make sure correct error is propagated Sam Vilain
2008-11-14 7:44 ` Francis Galiegue
2008-11-14 9:41 ` Sam Vilain
2008-11-14 19:05 ` Junio C Hamano
2008-11-14 19:09 ` Francis Galiegue [this message]
2008-11-14 19:50 ` Andreas Ericsson
2008-11-14 20:08 ` Francis Galiegue
2008-11-15 5:44 ` Junio C Hamano
2008-11-15 6:30 ` Sam Vilain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811142009.51803.fg@one2team.com \
--to=fg@one2team.com \
--cc=fge@one2team.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sam@vilain.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox