Git development
 help / color / mirror / Atom feed
From: Mark Burton <markb@ordern.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitk: Highlight found text only for when search type is "containing".
Date: Sun, 16 Nov 2008 00:05:53 +0000	[thread overview]
Message-ID: <20081116000553.3d04b513@crow> (raw)
In-Reply-To: <1226790769-25019-1-git-send-email-markb@ordern.com>


Hi,

The patch got sent without this blurb (not really sure how to send
patches to the list with leading blurb).

Anyway, I thought I would try and stop gitk from always highlighting
the text in the commit and comment panes that matches the text in the
search field. To me, it only makes sense to highlight the text when the
search type is "containing". For the other search types (definitely
for the touching paths type), I don't really see how having occurrences
of the search text highlighted helps.

I don't really understand how gitk operates but the patch does what I
want. I'm sure those in the know can improve on it if what it does is
useful.

Cheers,

Mark

      reply	other threads:[~2008-11-16  0:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-15 23:12 [PATCH] gitk: Highlight found text only for when search type is "containing" Mark Burton
2008-11-16  0:05 ` Mark Burton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081116000553.3d04b513@crow \
    --to=markb@ordern.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox