From: Petr Baudis <pasky@suse.cz>
To: "martin f. krafft" <madduck@debian.org>
Cc: git@vger.kernel.org
Subject: Re: [TopGit PATCH] Check for help invocation before setup
Date: Wed, 19 Nov 2008 19:24:36 +0100 [thread overview]
Message-ID: <20081119182436.GB10544@machine.or.cz> (raw)
In-Reply-To: <1227110623-4474-2-git-send-email-madduck@debian.org>
On Wed, Nov 19, 2008 at 05:03:40PM +0100, martin f. krafft wrote:
> diff --git a/tg.sh b/tg.sh
> index 2961106..40c4ab7 100644
> --- a/tg.sh
> +++ b/tg.sh
> @@ -235,6 +235,20 @@ do_help()
> fi
> }
>
> +## Startup
> +
> +args_saved="$@"
> +while [ -n "$1" ]; do
> + case "$1" in
> + help|--help|-h)
> + shift
> + do_help "$1"
> + exit 1;;
> + esac
> + shift
> +done
> +set -- $args_saved
> +unset args_saved
>
> ## Initial setup
Huh, why do you actually need $args_saved at all? :-) This is bound to
do horrible things with space-containing arguments etc., I think. You
don't need to do the outer shift and then drop $args_saved altogether,
no?
--
Petr "Pasky" Baudis
People who take cold baths never have rheumatism, but they have
cold baths.
next prev parent reply other threads:[~2008-11-19 18:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 16:03 [TopGit] Improve help output martin f. krafft
2008-11-19 16:03 ` [TopGit PATCH] Check for help invocation before setup martin f. krafft
2008-11-19 16:03 ` [TopGit PATCH] Change tg help exit code to 0 martin f. krafft
2008-11-19 16:03 ` [TopGit PATCH] Check for cmddir earlier martin f. krafft
2008-11-19 16:03 ` [TopGit PATCH] Print help output when no command is given martin f. krafft
2008-11-19 18:24 ` Petr Baudis [this message]
2008-11-19 18:32 ` [TopGit PATCH] Check for help invocation before setup martin f krafft
2008-11-19 18:39 ` Petr Baudis
2008-11-20 11:48 ` martin f krafft
2008-11-21 9:19 ` Bert Wesarg
2008-11-21 12:06 ` TopGit: ensure worktree (was: [TopGit PATCH] Check for help invocation before setup) martin f krafft
2008-11-21 12:09 ` [TopGit PATCH] Ensure we are inside a Git worktree martin f. krafft
2008-11-21 12:15 ` TopGit: ensure worktree (was: [TopGit PATCH] Check for help invocation before setup) Bert Wesarg
2008-11-21 12:18 ` Bert Wesarg
2008-11-21 12:31 ` martin f krafft
2008-11-21 12:23 ` martin f krafft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081119182436.GB10544@machine.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=madduck@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).