From: "Shawn O. Pearce" <spearce@spearce.org>
To: SZEDER GGGbor <szeder@ira.uka.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] bash: offer refs instead of filenames for 'git revert'
Date: Thu, 27 Nov 2008 13:30:12 -0800 [thread overview]
Message-ID: <20081127213012.GC23984@spearce.org> (raw)
In-Reply-To: <1227792953-4095-1-git-send-email-szeder@ira.uka.de>
SZEDER GGGbor <szeder@ira.uka.de> wrote:
> The completion script for 'git revert' currently offers options and
> filenames. However, 'git revert' doesn't take any filenames from the
> command line, but a single commit. Therefore, it's more sane to offer
> refs instead.
>
> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
Oh, good catch.
Acked-by: Shawn O. Pearce <spearce@spearce.org>
> ---
> contrib/completion/git-completion.bash | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 39bf18b..7e668d5 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1348,7 +1348,7 @@ _git_revert ()
> return
> ;;
> esac
> - COMPREPLY=()
> + __gitcomp "$(__git_refs)"
> }
>
> _git_rm ()
> --
> 1.6.0.4.814.gfe502
>
--
Shawn.
prev parent reply other threads:[~2008-11-27 21:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 13:35 [PATCH] bash: offer refs instead of filenames for 'git revert' SZEDER Gábor
2008-11-27 21:30 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081127213012.GC23984@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox