From: Joey Hess <joey@kitenet.net>
To: Ian Hilt <ian.hilt@gmx.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] sha1_file: avoid bogus "file exists" error message
Date: Fri, 28 Nov 2008 09:00:15 -0800 [thread overview]
Message-ID: <20081128170015.GA9744@kodama.kitenet.net> (raw)
In-Reply-To: <alpine.LFD.2.00.0811271233590.2883@sys-0.hiltweb.site>
[-- Attachment #1: Type: text/plain, Size: 773 bytes --]
Ian Hilt wrote:
> On Wed, 26 Nov 2008, Joey Hess wrote:
> > Joey Hess wrote:
> > > Note that in both occasions that I've seen this failure, it has not been
> > > due to a missing directory, or bad permissions
> >
> > Actually, it was due to bad permissions. :-) Once git was fixed to
> > actually say that, I figured out where to look to fix them.
>
> This is strange since write_loose_object() which calls create_tmpfile()
> checks for EPERM. Perhaps this should be done in create_tmpfile()?
errno is clobbered by the mkdir in create_tmpfile(), that's what my patch
corrects.
I suspect that in my case, mkstemp failed with EACCES, not EPERM. git
was running as a group that did not have write access to (some) object
directories.
--
see shy jo
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2008-11-28 17:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 18:56 [PATCH] sha1_file: avoid bogus "file exists" error message Joey Hess
2008-11-26 18:19 ` Joey Hess
2008-11-27 17:41 ` Ian Hilt
2008-11-28 17:00 ` Joey Hess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081128170015.GA9744@kodama.kitenet.net \
--to=joey@kitenet.net \
--cc=git@vger.kernel.org \
--cc=ian.hilt@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).