From: Alexander Gavrilov <angavrilov@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Paul Mackerras <paulus@samba.org>,
Git Mailing List <git@vger.kernel.org>
Subject: [PATCH (GITK FIX)] gitk: Fix the "notflag: no such variable" error in --not processing.
Date: Mon, 1 Dec 2008 20:25:25 +0300 [thread overview]
Message-ID: <200812012025.25286.angavrilov@gmail.com> (raw)
In-Reply-To: <49341101.8050400@viscovery.net>
Commit 2958228430b63f2e38c55519d1f98d8d6d9e23f3 fixed the
switch statement used in option processing, which made some of
the previously unreachable cases executable. This uncovered the
fact that the variable used in the handling of the --not option is not
initialized.
This patch initializes it. Note that actually it is also possible to
remove it completely, because currently nobody uses the value.
Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
---
On Monday 01 December 2008 19:29:53 Johannes Sixt wrote:
> > $ git bisect view
> > Error in startup script: can't read "notflag": no such variable
> > while executing
> > "expr {!$notflag}"
> > ("--not" arm line 2)
> > invoked from within
> > "switch -glob -- $arg {
> > "-d" -
> > "--date-order" {
> > set vdatemode($n) 1
> > # remove from origargs in case we hit an unknown option
> > set origarg..."
> > (procedure "parseviewargs" line 21)
> > invoked from within
> > "parseviewargs $view $args"
> > (procedure "start_rev_list" line 27)
> > invoked from within
> > "start_rev_list $curview"
> > (procedure "getcommits" line 5)
> > invoked from within
> > "getcommits {}"
> > (file "/usr/local/bin/gitk" line 10897)
>
> Bisection points to this commit:
>
> commit 2958228430b63f2e38c55519d1f98d8d6d9e23f3
gitk | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gitk b/gitk
index f7f1776..6eaeadf 100755
--- a/gitk
+++ b/gitk
@@ -139,6 +139,7 @@ proc parseviewargs {n arglist} {
set origargs $arglist
set allknown 1
set filtered 0
+ set notflag 0
set i -1
foreach arg $arglist {
incr i
--
1.6.0.4.30.gf4240
next prev parent reply other threads:[~2008-12-01 17:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 14:43 gitk: git bisect view doesn't work Johannes Sixt
2008-12-01 16:29 ` Johannes Sixt
2008-12-01 17:25 ` Alexander Gavrilov [this message]
2008-12-01 22:45 ` [PATCH (GITK FIX)] gitk: Fix the "notflag: no such variable" error in --not processing Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812012025.25286.angavrilov@gmail.com \
--to=angavrilov@gmail.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).