From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 5/6 (v2)] upload-pack: send the HEAD information
Date: Mon, 1 Dec 2008 20:59:25 -0500 [thread overview]
Message-ID: <20081202015924.GA6529@coredump.intra.peff.net> (raw)
In-Reply-To: <7vk5ajqs63.fsf@gitster.siamese.dyndns.org>
On Mon, Dec 01, 2008 at 05:31:16PM -0800, Junio C Hamano wrote:
> > Yuck. My two complaints are:
> >
> > (1) this implicitly handles only the HEAD symref.
>
> But this information *is* on the "40-hex name" line that describes the
> HEAD ;-)
Ahhh. OK. I see, I misunderstood the protocol a bit. So let me revise my
complaints. ;)
(1) If there are multiple symrefs to report, we have to keep
re-sending the server capabilities (I think you mentioned this in
the subthread with Shawn).
(2) Similar to (2) before. If we ever add a _third_ extra slot, we
will be stuck sending the symref field each time we want to use
that third slot (though if the client properly treats an empty
slot the same as non-existent, this only wastes a single byte for
the NUL).
(3) If HEAD doesn't point to a valid object, we have no place to put
the symref. Or is it kosher to say
0000000000000000000000000000000000000000 HEAD\0...\0refs/heads/master
? I think it would be nice eventually to be able to clone a HEAD
pointing to yet-to-be-born branch.
-Peff
next prev parent reply other threads:[~2008-12-02 2:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 14:12 [PATCH 0/6 (v2)] Detecting HEAD more reliably while cloning Junio C Hamano
2008-12-01 14:12 ` [PATCH 1/6 (v2)] get_remote_heads(): refactor code to read "server capabilities" Junio C Hamano
2008-12-01 14:12 ` [PATCH 2/6 (v2)] connect.c::read_extra_info(): prepare to receive more than server capabilities Junio C Hamano
2008-12-01 14:12 ` [PATCH 3/6 (v2)] connect.c::read_extra_info(): find where HEAD points at Junio C Hamano
2008-12-01 14:12 ` [PATCH 4/6 (v2)] clone: find the current branch more explicitly Junio C Hamano
2008-12-01 14:12 ` [PATCH 5/6 (v2)] upload-pack: send the HEAD information Junio C Hamano
2008-12-01 14:12 ` [PATCH 6/6 (v2)] clone: test the new HEAD detection logic Junio C Hamano
2008-12-01 15:40 ` [PATCH 5/6 (v2)] upload-pack: send the HEAD information Jakub Narebski
2008-12-01 16:20 ` Shawn O. Pearce
2008-12-01 19:54 ` Junio C Hamano
2008-12-01 17:44 ` Jeff King
2008-12-02 1:31 ` Junio C Hamano
2008-12-02 1:59 ` Jeff King [this message]
2008-12-02 2:20 ` Junio C Hamano
2008-12-02 2:36 ` Jeff King
2008-12-01 15:52 ` [PATCH 0/6 (v2)] Detecting HEAD more reliably while cloning Johannes Sixt
2008-12-02 1:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081202015924.GA6529@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).