* [PATCH] t4030-diff-textconv: Make octal escape sequence more portable
@ 2008-12-02 8:31 Johannes Sixt
2008-12-02 12:54 ` Jeff King
2008-12-03 2:18 ` Junio C Hamano
0 siblings, 2 replies; 3+ messages in thread
From: Johannes Sixt @ 2008-12-02 8:31 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Jeff King, Git Mailing List
From: Johannes Sixt <j6t@kdbg.org>
There are printfs around that do not grok '\1', but need '\01'.
Discovered on AIX 4.3.x.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
I found no other instance of printf backslash-nonzero.
t/t4030-diff-textconv.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t4030-diff-textconv.sh b/t/t4030-diff-textconv.sh
index 03ba26a..4e961df 100755
--- a/t/t4030-diff-textconv.sh
+++ b/t/t4030-diff-textconv.sh
@@ -29,7 +29,7 @@ test_expect_success 'setup binary file with history' '
printf "\\0\\n" >file &&
git add file &&
git commit -m one &&
- printf "\\1\\n" >>file &&
+ printf "\\01\\n" >>file &&
git add file &&
git commit -m two
'
--
1.6.1.rc1.5.gf691f
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] t4030-diff-textconv: Make octal escape sequence more portable
2008-12-02 8:31 [PATCH] t4030-diff-textconv: Make octal escape sequence more portable Johannes Sixt
@ 2008-12-02 12:54 ` Jeff King
2008-12-03 2:18 ` Junio C Hamano
1 sibling, 0 replies; 3+ messages in thread
From: Jeff King @ 2008-12-02 12:54 UTC (permalink / raw)
To: Johannes Sixt; +Cc: Junio C Hamano, Git Mailing List
On Tue, Dec 02, 2008 at 09:31:01AM +0100, Johannes Sixt wrote:
> There are printfs around that do not grok '\1', but need '\01'.
> Discovered on AIX 4.3.x.
Whee. Your fix works fine on my platforms (Solaris + FreeBSD).
> I found no other instance of printf backslash-nonzero.
Me either.
-Peff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] t4030-diff-textconv: Make octal escape sequence more portable
2008-12-02 8:31 [PATCH] t4030-diff-textconv: Make octal escape sequence more portable Johannes Sixt
2008-12-02 12:54 ` Jeff King
@ 2008-12-03 2:18 ` Junio C Hamano
1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2008-12-03 2:18 UTC (permalink / raw)
To: Johannes Sixt; +Cc: Jeff King, Git Mailing List
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-12-03 2:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-02 8:31 [PATCH] t4030-diff-textconv: Make octal escape sequence more portable Johannes Sixt
2008-12-02 12:54 ` Jeff King
2008-12-03 2:18 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).