* [StGit PATCH] Do not append a new line to the backwards compat files (bug #12656)
@ 2008-12-02 14:38 Catalin Marinas
2008-12-02 15:39 ` Karl Hasselström
0 siblings, 1 reply; 2+ messages in thread
From: Catalin Marinas @ 2008-12-02 14:38 UTC (permalink / raw)
To: Karl Hasselström; +Cc: git
Since the multiline argument wasn't passed to the utils.write_string()
function when writing the compatibility description file from the new
infrastructure, any older command like push would have committed these
new lines.
Signed-off-by: Catalin Marinas <catalin.marinas@gmail.com>
---
stgit/lib/stack.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/stgit/lib/stack.py b/stgit/lib/stack.py
index 47679b6..a72ee22 100644
--- a/stgit/lib/stack.py
+++ b/stgit/lib/stack.py
@@ -58,7 +58,7 @@ class Patch(object):
write('authdate', d.author.date)
write('commname', d.committer.name)
write('commemail', d.committer.email)
- write('description', d.message)
+ write('description', d.message, multiline = True)
write('log', write_patchlog().sha1)
write('top', new_commit.sha1)
write('bottom', d.parent.sha1)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [StGit PATCH] Do not append a new line to the backwards compat files (bug #12656)
2008-12-02 14:38 [StGit PATCH] Do not append a new line to the backwards compat files (bug #12656) Catalin Marinas
@ 2008-12-02 15:39 ` Karl Hasselström
0 siblings, 0 replies; 2+ messages in thread
From: Karl Hasselström @ 2008-12-02 15:39 UTC (permalink / raw)
To: Catalin Marinas; +Cc: git
On 2008-12-02 14:38:39 +0000, Catalin Marinas wrote:
> Since the multiline argument wasn't passed to the
> utils.write_string() function when writing the compatibility
> description file from the new infrastructure, any older command like
> push would have committed these new lines.
>
> Signed-off-by: Catalin Marinas <catalin.marinas@gmail.com>
Acked-by: Karl Hasselström <kha@treskal.com>
Thanks.
--
Karl Hasselström, kha@treskal.com
www.treskal.com/kalle
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-02 15:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-02 14:38 [StGit PATCH] Do not append a new line to the backwards compat files (bug #12656) Catalin Marinas
2008-12-02 15:39 ` Karl Hasselström
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).