From: Jeff King <peff@peff.net>
To: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] Allow passing of --directory to git-am.
Date: Thu, 4 Dec 2008 13:51:38 -0500 [thread overview]
Message-ID: <20081204185138.GA24858@coredump.intra.peff.net> (raw)
In-Reply-To: <49382612.3010207@fs.ei.tum.de>
On Thu, Dec 04, 2008 at 07:48:50PM +0100, Simon 'corecode' Schubert wrote:
> Boyd Stephen Smith Jr. wrote:
> > I'm thinking your sed line doesn't do what you think it does. You
> probably
> > want something like:
> > bss@monster:~$ echo "don't" | sed -e "s/'/'\\\\''/g"
> > don'\''t
>
> Thanks, I clearly did not test this well enough.
Maybe it would be a good idea to add a test to the test script, then?
-Peff
next prev parent reply other threads:[~2008-12-04 18:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 18:48 [PATCH] Allow passing of --directory to git-am Simon 'corecode' Schubert
2008-12-04 18:51 ` Jeff King [this message]
2008-12-04 19:27 ` Junio C Hamano
2008-12-04 22:26 ` Simon 'corecode' Schubert
2008-12-04 22:33 ` Junio C Hamano
2008-12-04 23:14 ` Junio C Hamano
2008-12-04 23:36 ` [PATCH - DONTUSE] git-am: propagate -C/-p as well Junio C Hamano
2008-12-04 23:41 ` [PATCH] Allow passing of --directory to git-am Simon 'corecode' Schubert
2008-12-05 0:11 ` Junio C Hamano
2008-12-05 0:16 ` Simon 'corecode' Schubert
2008-12-04 19:35 ` Jakub Narebski
2008-12-04 22:25 ` Simon 'corecode' Schubert
2008-12-04 22:46 ` Jakub Narebski
-- strict thread matches above, loose matches on Subject: below --
2008-12-04 17:04 Simon 'corecode' Schubert
2008-12-04 18:28 ` Boyd Stephen Smith Jr.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204185138.GA24858@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=corecode@fs.ei.tum.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).